diff mbox series

generic/089: increase the lock timeout to 120s

Message ID 20240126201550.109929-1-jlayton@kernel.org (mailing list archive)
State New, archived
Headers show
Series generic/089: increase the lock timeout to 120s | expand

Commit Message

Jeff Layton Jan. 26, 2024, 8:15 p.m. UTC
On NFS, this test can take a long time. There is enough contention for
the lock that it can take more than 10s (or even 60s) to acquire it.

Bump this value up to 120s, which seems to be long enough for testing
with kdevops.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 src/t_mtab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Feb. 2, 2024, 1 p.m. UTC | #1
On Fri, Jan 26, 2024 at 03:15:50PM -0500, Jeff Layton wrote:
> On NFS, this test can take a long time. There is enough contention for
> the lock that it can take more than 10s (or even 60s) to acquire it.
> 
> Bump this value up to 120s, which seems to be long enough for testing
> with kdevops.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

Good to me,

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  src/t_mtab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/t_mtab.c b/src/t_mtab.c
> index c0640a1951a4..4b3b26c86d02 100644
> --- a/src/t_mtab.c
> +++ b/src/t_mtab.c
> @@ -16,7 +16,7 @@
>  #include <mntent.h>
>  #include <limits.h>
>  
> -#define LOCK_TIMEOUT	10
> +#define LOCK_TIMEOUT	120
>  #define _(x)		(x)
>  
>  static char *mounted = "t_mtab";
> -- 
> 2.43.0
> 
>
diff mbox series

Patch

diff --git a/src/t_mtab.c b/src/t_mtab.c
index c0640a1951a4..4b3b26c86d02 100644
--- a/src/t_mtab.c
+++ b/src/t_mtab.c
@@ -16,7 +16,7 @@ 
 #include <mntent.h>
 #include <limits.h>
 
-#define LOCK_TIMEOUT	10
+#define LOCK_TIMEOUT	120
 #define _(x)		(x)
 
 static char *mounted = "t_mtab";