| Message ID | 20240408133243.694134-6-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] xfs: remove support for tools and kernels with v5 support | expand |
On Mon, Apr 08, 2024 at 03:32:42PM +0200, Christoph Hellwig wrote: > Replace crc as the main test feature with reflink so that this test > do not require v4 file system support. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Pretty straight conversion, so Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > tests/xfs/522 | 58 +++++++++++++++++++++++++-------------------------- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/tests/xfs/522 b/tests/xfs/522 > index 2475d5844..05251b0e2 100755 > --- a/tests/xfs/522 > +++ b/tests/xfs/522 > @@ -46,58 +46,58 @@ test_mkfs_config() { > echo Simplest config file > cat > $def_cfgfile << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config $def_cfgfile > > echo Piped-in config file > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 1 > +reflink = 1 > ENDL > > echo Full line comment > test_mkfs_config << ENDL > # This is a full line comment. > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > # This is a full line comment. > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > #This is a full line comment. > [metadata] > -crc = 0 > +reflink = 0 > ENDL > > echo End of line comment > test_mkfs_config << ENDL > [metadata] > -crc = 0 ; This is an eol comment. > +reflink = 0 ; This is an eol comment. > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 0 ;This is an eol comment. > +reflink = 0 ;This is an eol comment. > ENDL > > echo Multiple directives > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > finobt = 0 > ENDL > > echo Multiple sections > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > > [inode] > sparse = 0 > @@ -111,92 +111,92 @@ ENDL > echo Space around the section name > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > > echo Single space around the key/value directive > test_mkfs_config << ENDL > [metadata] > - crc=0 > + reflink=0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc =0 > +reflink =0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc= 0 > +reflink= 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc=0 > +reflink=0 > ENDL > > echo Two spaces around the key/value directive > test_mkfs_config << ENDL > [metadata] > - crc =0 > + reflink =0 > ENDL > test_mkfs_config << ENDL > [metadata] > - crc= 0 > + reflink= 0 > ENDL > test_mkfs_config << ENDL > [metadata] > - crc=0 > + reflink=0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc =0 > +reflink =0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc= 0 > +reflink= 0 > ENDL > > echo Three spaces around the key/value directive > test_mkfs_config << ENDL > [metadata] > - crc = 0 > + reflink = 0 > ENDL > test_mkfs_config << ENDL > [metadata] > - crc= 0 > + reflink= 0 > ENDL > test_mkfs_config << ENDL > [metadata] > -crc = 0 > +reflink = 0 > ENDL > > echo Four spaces around the key/value directive > test_mkfs_config << ENDL > [metadata] > - crc = 0 > + reflink = 0 > ENDL > > echo Arbitrary spaces and tabs > test_mkfs_config << ENDL > [metadata] > - crc = 0 > + reflink = 0 > ENDL > > echo ambiguous comment/section names > test_mkfs_config << ENDL > [metadata] > #[data] > -crc = 0 > +reflink = 0 > ENDL > > echo ambiguous comment/variable names > -- > 2.39.2 > >
diff --git a/tests/xfs/522 b/tests/xfs/522 index 2475d5844..05251b0e2 100755 --- a/tests/xfs/522 +++ b/tests/xfs/522 @@ -46,58 +46,58 @@ test_mkfs_config() { echo Simplest config file cat > $def_cfgfile << ENDL [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config $def_cfgfile echo Piped-in config file test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL [metadata] -crc = 1 +reflink = 1 ENDL echo Full line comment test_mkfs_config << ENDL # This is a full line comment. [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL # This is a full line comment. [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL #This is a full line comment. [metadata] -crc = 0 +reflink = 0 ENDL echo End of line comment test_mkfs_config << ENDL [metadata] -crc = 0 ; This is an eol comment. +reflink = 0 ; This is an eol comment. ENDL test_mkfs_config << ENDL [metadata] -crc = 0 ;This is an eol comment. +reflink = 0 ;This is an eol comment. ENDL echo Multiple directives test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 finobt = 0 ENDL echo Multiple sections test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 [inode] sparse = 0 @@ -111,92 +111,92 @@ ENDL echo Space around the section name test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL echo Single space around the key/value directive test_mkfs_config << ENDL [metadata] - crc=0 + reflink=0 ENDL test_mkfs_config << ENDL [metadata] -crc =0 +reflink =0 ENDL test_mkfs_config << ENDL [metadata] -crc= 0 +reflink= 0 ENDL test_mkfs_config << ENDL [metadata] -crc=0 +reflink=0 ENDL echo Two spaces around the key/value directive test_mkfs_config << ENDL [metadata] - crc =0 + reflink =0 ENDL test_mkfs_config << ENDL [metadata] - crc= 0 + reflink= 0 ENDL test_mkfs_config << ENDL [metadata] - crc=0 + reflink=0 ENDL test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL test_mkfs_config << ENDL [metadata] -crc =0 +reflink =0 ENDL test_mkfs_config << ENDL [metadata] -crc= 0 +reflink= 0 ENDL echo Three spaces around the key/value directive test_mkfs_config << ENDL [metadata] - crc = 0 + reflink = 0 ENDL test_mkfs_config << ENDL [metadata] - crc= 0 + reflink= 0 ENDL test_mkfs_config << ENDL [metadata] -crc = 0 +reflink = 0 ENDL echo Four spaces around the key/value directive test_mkfs_config << ENDL [metadata] - crc = 0 + reflink = 0 ENDL echo Arbitrary spaces and tabs test_mkfs_config << ENDL [metadata] - crc = 0 + reflink = 0 ENDL echo ambiguous comment/section names test_mkfs_config << ENDL [metadata] #[data] -crc = 0 +reflink = 0 ENDL echo ambiguous comment/variable names
Replace crc as the main test feature with reflink so that this test do not require v4 file system support. Signed-off-by: Christoph Hellwig <hch@lst.de> --- tests/xfs/522 | 58 +++++++++++++++++++++++++-------------------------- 1 file changed, 29 insertions(+), 29 deletions(-)