| Message ID | 20240720071323.2893437-1-yangerkun@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic/732: don't run it on tmpfs | expand |
On Sat, Jul 20, 2024 at 03:13:23PM +0800, Yang Erkun wrote: > Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same > options for tmpfs won't share the same backend. Skip it for tmpfs. > > # real QA test starts here > -_supported_fs ^nfs ^overlay > +_supported_fs ^nfs ^overlay ^tmpfs Can you please spell out the explanation here? We should not have a _supported_fs call without a comment explaining it.
Hi, Sorry for the delay relay(something happened, and cannot use pc before...). 在 2024/7/22 22:20, Christoph Hellwig 写道: > On Sat, Jul 20, 2024 at 03:13:23PM +0800, Yang Erkun wrote: >> Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same >> options for tmpfs won't share the same backend. Skip it for tmpfs. >> >> # real QA test starts here >> -_supported_fs ^nfs ^overlay >> +_supported_fs ^nfs ^overlay ^tmpfs > > Can you please spell out the explanation here? > > We should not have a _supported_fs call without a comment explaining it. > > Yeah! Thanks for your reminder, will do it with v2(maybe until last week I can do it).
diff --git a/tests/generic/732 b/tests/generic/732 index 7a40f49b..2b83f216 100755 --- a/tests/generic/732 +++ b/tests/generic/732 @@ -22,7 +22,7 @@ _cleanup() } # real QA test starts here -_supported_fs ^nfs ^overlay +_supported_fs ^nfs ^overlay ^tmpfs _require_test _require_scratch
Like what 4fd042e0465c("generic/732: don't run it on NFS") say, the same options for tmpfs won't share the same backend. Skip it for tmpfs. Signed-off-by: Yang Erkun <yangerkun@huawei.com> --- tests/generic/732 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)