diff mbox series

generic/754: fix _fixed_by tags

Message ID 20240726165107.GR103020@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series generic/754: fix _fixed_by tags | expand

Commit Message

Darrick J. Wong July 26, 2024, 4:51 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

This test requires an xfs_repair patch, so note that in the test.  Also
update the kernel git hash since we now have one.

Reported-by: maxj.fnst@fujitsu.com
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/754 |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig July 26, 2024, 5:14 p.m. UTC | #1
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Zorro Lang July 26, 2024, 5:17 p.m. UTC | #2
On Fri, Jul 26, 2024 at 09:51:07AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This test requires an xfs_repair patch, so note that in the test.  Also
> update the kernel git hash since we now have one.
> 
> Reported-by: maxj.fnst@fujitsu.com
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  tests/generic/754 |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/754 b/tests/generic/754
> index f73d1ed611..7afda609f5 100755
> --- a/tests/generic/754
> +++ b/tests/generic/754
> @@ -13,9 +13,12 @@ _begin_fstest auto
>  
>  _require_scratch
>  
> -test $FSTYP = "xfs" && \
> -	_fixed_by_git_commit kernel XXXXXXXXXXXXX \
> +if [ $FSTYP = "xfs" ]; then
> +	_fixed_by_git_commit kernel 38de567906d95 \
>  			"xfs: allow symlinks with short remote targets"
> +	_fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
> +			"xfs_repair: small remote symlinks are ok"

Thanks for this update.

Reviewed-by: Zorro Lang <zlang@redhat.com>

> +fi
>  
>  _scratch_mkfs >> $seqres.full
>  _scratch_mount >> $seqres.full
>
diff mbox series

Patch

diff --git a/tests/generic/754 b/tests/generic/754
index f73d1ed611..7afda609f5 100755
--- a/tests/generic/754
+++ b/tests/generic/754
@@ -13,9 +13,12 @@  _begin_fstest auto
 
 _require_scratch
 
-test $FSTYP = "xfs" && \
-	_fixed_by_git_commit kernel XXXXXXXXXXXXX \
+if [ $FSTYP = "xfs" ]; then
+	_fixed_by_git_commit kernel 38de567906d95 \
 			"xfs: allow symlinks with short remote targets"
+	_fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
+			"xfs_repair: small remote symlinks are ok"
+fi
 
 _scratch_mkfs >> $seqres.full
 _scratch_mount >> $seqres.full