| Message ID | 20240731114150.2259760-1-maharmstone@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common/fail_make_request: fix error message | expand |
Would someone mind accepting this patch please? This incorrect error message keeps tripping me up whenever I'm trying to configure a kernel to work with fstests. Thanks On 31/7/24 12:41, Mark Harmstone wrote: > fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST > to function, not CONFIG_FAULT_INJECTION_DEBUG_FS. > > Signed-off-by: Mark Harmstone <maharmstone@fb.com> > --- > common/fail_make_request | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/fail_make_request b/common/fail_make_request > index b5370ba6..56402021 100644 > --- a/common/fail_make_request > +++ b/common/fail_make_request > @@ -7,7 +7,7 @@ _require_fail_make_request() > { > [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \ > || _notrun "$DEBUGFS_MNT/fail_make_request \ > - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled" > + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled" > } > > _allow_fail_make_request()
On Wed, Jul 31, 2024 at 12:41:33PM +0100, Mark Harmstone wrote: > fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST > to function, not CONFIG_FAULT_INJECTION_DEBUG_FS. > > Signed-off-by: Mark Harmstone <maharmstone@fb.com> > --- Make sense to me. Maybe it want to write CONFIG_FAULT_INJECTION, anyway, Reviewed-by: Zorro Lang <zlang@redhat.com> > common/fail_make_request | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/fail_make_request b/common/fail_make_request > index b5370ba6..56402021 100644 > --- a/common/fail_make_request > +++ b/common/fail_make_request > @@ -7,7 +7,7 @@ _require_fail_make_request() > { > [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \ > || _notrun "$DEBUGFS_MNT/fail_make_request \ > - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled" > + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled" > } > > _allow_fail_make_request() > -- > 2.44.2 > >
diff --git a/common/fail_make_request b/common/fail_make_request index b5370ba6..56402021 100644 --- a/common/fail_make_request +++ b/common/fail_make_request @@ -7,7 +7,7 @@ _require_fail_make_request() { [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \ || _notrun "$DEBUGFS_MNT/fail_make_request \ - not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled" + not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled" } _allow_fail_make_request()
fail_make_request depends on the kernel option CONFIG_FAIL_MAKE_REQUEST to function, not CONFIG_FAULT_INJECTION_DEBUG_FS. Signed-off-by: Mark Harmstone <maharmstone@fb.com> --- common/fail_make_request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)