From patchwork Mon Oct 28 14:18:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 13853582 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05F981DA631 for ; Mon, 28 Oct 2024 14:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730125090; cv=none; b=K7LURqe1spKh7oNvjrsN7PwC/QGMRw8zd0WSwo01PAxsA8+MmLWeJhnSa+F4u5//1tvzYJSmMI8uW/j5YGSEWXaVMbCG090ZwzsHrGDXRa9e0herWR4ekAAzf02DTLEfTF7sfyavxGG+ZYXjbU+r1AbriTyFe9yqinVb+R/Zt9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730125090; c=relaxed/simple; bh=pexBdKDgTINKrNIruMOIrMyMh+9Vaidlv8kP7M2pspg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EUSRUETFewdloakboihnEpiiIrkLd53oL3G0KtC+yKBmYl3XSFsvXLURyMM8z9NdR87HjxFm0xCGtG4ZSCZq1srYuQnQKaysrJNTyAOBncL69b1GvH3twttdvlIFSi06Img3v8OpoHda8G9g0SApwwZYMouqtS3DzkD6Iw4nSLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AuZuJ2g/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AuZuJ2g/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CB01C4CECD; Mon, 28 Oct 2024 14:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730125089; bh=pexBdKDgTINKrNIruMOIrMyMh+9Vaidlv8kP7M2pspg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AuZuJ2g/FgHXHw5HxA3KZG2gTkJB9mCzpt933hoIW0eDFxN7dHNPTP+te4W6PQDZu 7T/ikKiTa4Lj/oefDGVZLGKXtQavEWy/i5GMexaoZsSZiC9+nkfau5u3ew6cmtnciw qOHloyh1ZxQTlEeK5tl1YwSilEX5r8f14dVhr6KDmFTKpIpDhFw7kSPJrYm/M0gVhL QPMGebX3oX4ecDEspRr2z413uu3LFQQsPLSAceAKT09v5mTOZKrb+TuvbITTCxXF5J 5fBGh+Sx6CUEN19AxeHdGds0bXttE2SltIamBh1EtFVokQsA6GqNDUPwPD2XSl8lck iDoxGmdtMIJhA== From: Chao Yu To: Zorro Lang Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Chao Yu , Jaegeuk Kim , Qi Han Subject: [PATCH v3 2/2] f2fs/007: add testcase to check consistency of compressed inode metadata Date: Mon, 28 Oct 2024 22:18:00 +0800 Message-Id: <20241028141800.1788356-2-chao@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20241028141800.1788356-1-chao@kernel.org> References: <20241028141800.1788356-1-chao@kernel.org> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 metadata of compressed inode should always be consistent after file compression, reservation, releasement and decompression, let's add a testcase to check it. Cc: Jaegeuk Kim Cc: Qi Han Signed-off-by: Chao Yu Reviewed-by: Zorro Lang --- v3: - move _require_scratch before use of $SCRATCH_MNT - output message before _check_scratch_fs tests/f2fs/007 | 108 +++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/007.out | 16 +++++++ 2 files changed, 124 insertions(+) create mode 100755 tests/f2fs/007 create mode 100644 tests/f2fs/007.out diff --git a/tests/f2fs/007 b/tests/f2fs/007 new file mode 100755 index 00000000..805d88fa --- /dev/null +++ b/tests/f2fs/007 @@ -0,0 +1,108 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2024 Oppo. All Rights Reserved. +# +# FS QA Test No. f2fs/007 +# +# This is a regression test to check whether compressed metadata +# can become inconsistent after file compression, reservation +# releasement, and decompression. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks" + +_require_scratch +testfile_prefix=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +cat >$fio_config <> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_mode=user,compress_extension=*" >> $seqres.full + +echo -e "Run fio to initialize file w/ specified compress ratio" >> $seqres.full +cat $fio_config >> $seqres.full +$FIO_PROG $fio_config >> $seqres.full +_scratch_unmount + +# force to repaire if filesystem is corrupted +export FSCK_OPTIONS="-f $FSCK_OPTIONS" + +for i in 30 60 90; do + testfile=$testfile_prefix$i + + _scratch_mount "-o compress_mode=user" >> $seqres.full + $F2FS_IO_PROG compress $testfile >> $seqres.full + cblocks=`$F2FS_IO_PROG get_cblocks $testfile` + echo "compression ratio is: "$cblocks" / 256" + + _scratch_unmount + + # 1. check after compression + echo "check fs after compress" + _check_scratch_fs + + _scratch_mount >> $seqres.full + $F2FS_IO_PROG release_cblocks $testfile >> $seqres.full + _scratch_unmount + + # 2. check after releasement + echo "check fs after release_cblocks" + _check_scratch_fs + + _scratch_mount >> $seqres.full + $F2FS_IO_PROG reserve_cblocks $testfile >> $seqres.full + _scratch_unmount + + # 3. check after rservation + echo "check fs after reserve_cblocks" + _check_scratch_fs + + _scratch_mount "-o compress_mode=user" >> $seqres.full + $F2FS_IO_PROG decompress $testfile >> $seqres.full + _scratch_unmount + + # 4. check after decompression + echo "check fs after decompress" + _check_scratch_fs +done + +status=0 +exit diff --git a/tests/f2fs/007.out b/tests/f2fs/007.out new file mode 100644 index 00000000..a4b76300 --- /dev/null +++ b/tests/f2fs/007.out @@ -0,0 +1,16 @@ +QA output created by 007 +compression ratio is: 64 / 256 +check fs after compress +check fs after release_cblocks +check fs after reserve_cblocks +check fs after decompress +compression ratio is: 128 / 256 +check fs after compress +check fs after release_cblocks +check fs after reserve_cblocks +check fs after decompress +compression ratio is: 192 / 256 +check fs after compress +check fs after release_cblocks +check fs after reserve_cblocks +check fs after decompress