| Message ID | 20250414120102.400383-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | generic/231: use relative path to invoke fsx | expand |
On Mon, Apr 14, 2025 at 02:01:02PM +0200, Christoph Hellwig wrote: > This test uses su to run fsx as $qa_user. Because the shell calling > fsx is run as $qa_user it might not be able to access the xfstests or > parent directory which might only be accessible to the user xfstests > is run as (e.g. root). Switch back to calling fsx using a relative > path, partially reverting commit 1c67e8b191fe > ("config: add FSX_PROG variable"). > > Signed-off-by: Christoph Hellwig <hch@lst.de> I make the same statement about leaving a note about using relative paths in the comments as I had for the previous fix. With that applied here, Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > tests/generic/231 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/generic/231 b/tests/generic/231 > index b598a5d568bd..8dda926d875e 100755 > --- a/tests/generic/231 > +++ b/tests/generic/231 > @@ -23,8 +23,8 @@ _fsx() > echo "=== FSX Standard Mode, Memory Mapping, $tasks Tasks ===" > for (( i = 1; i <= $tasks; i++ )); do > SEED=$RANDOM > - echo "$FSX_PROG $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full > - _su $qa_user -c "$FSX_PROG $FSX_ARGS -S $SEED \ > + echo "ltp/fsx $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full > + _su $qa_user -c "ltp/fsx $FSX_ARGS -S $SEED \ > $FSX_AVOID $SCRATCH_MNT/fsx_file$i" >$tmp.output$i 2>&1 & > done > > -- > 2.47.2 > >
diff --git a/tests/generic/231 b/tests/generic/231 index b598a5d568bd..8dda926d875e 100755 --- a/tests/generic/231 +++ b/tests/generic/231 @@ -23,8 +23,8 @@ _fsx() echo "=== FSX Standard Mode, Memory Mapping, $tasks Tasks ===" for (( i = 1; i <= $tasks; i++ )); do SEED=$RANDOM - echo "$FSX_PROG $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full - _su $qa_user -c "$FSX_PROG $FSX_ARGS -S $SEED \ + echo "ltp/fsx $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full + _su $qa_user -c "ltp/fsx $FSX_ARGS -S $SEED \ $FSX_AVOID $SCRATCH_MNT/fsx_file$i" >$tmp.output$i 2>&1 & done
This test uses su to run fsx as $qa_user. Because the shell calling fsx is run as $qa_user it might not be able to access the xfstests or parent directory which might only be accessible to the user xfstests is run as (e.g. root). Switch back to calling fsx using a relative path, partially reverting commit 1c67e8b191fe ("config: add FSX_PROG variable"). Signed-off-by: Christoph Hellwig <hch@lst.de> --- tests/generic/231 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)