diff mbox series

[1/2] generic/231: use relative path to invoke fsx

Message ID 20250416045112.617815-1-hch@lst.de (mailing list archive)
State New
Headers show
Series [1/2] generic/231: use relative path to invoke fsx | expand

Commit Message

Christoph Hellwig April 16, 2025, 4:51 a.m. UTC 
This test uses su to run fsx as $qa_user.  Because the shell calling
fsx is run as $qa_user it might not be able to access the xfstests or
parent directory which might only be accessible to the user xfstests
is run as (e.g. root).  Switch back to calling fsx using a relative
path, partially reverting commit 1c67e8b191fe
("config: add FSX_PROG variable").

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
 tests/generic/231 | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/tests/generic/231 b/tests/generic/231
index b598a5d568bd..ce7e62ea1886 100755
--- a/tests/generic/231
+++ b/tests/generic/231
@@ -23,8 +23,10 @@  _fsx()
 	echo "=== FSX Standard Mode, Memory Mapping, $tasks Tasks ==="
 	for (( i = 1; i <= $tasks; i++ )); do
 		SEED=$RANDOM
-		echo "$FSX_PROG $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full
-		_su $qa_user -c "$FSX_PROG $FSX_ARGS -S $SEED \
+		# The absolute path $here might not be traversable (+x) for
+		# $qa_user, so supply a relative path to fsx here.
+		echo "ltp/fsx $FSX_ARGS -S $SEED $SCRATCH_MNT/fsx_file$i" >>$seqres.full
+		_su $qa_user -c "ltp/fsx $FSX_ARGS -S $SEED \
 			$FSX_AVOID $SCRATCH_MNT/fsx_file$i" >$tmp.output$i 2>&1 &
 	done