| Message ID | 2fc42b09cdc710cc2ac83e3a1726b5f7b1d0af62.1693312237.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: btrfs add more tests into the scrub group | expand |
On Tue, Aug 29, 2023 at 08:32:40PM +0800, Anand Jain wrote: > I wanted to verify tests using the command "btrfs scrub start" and > found that there are many more test cases using "btrfs scrub start" > than what is listed in the group.list file. So, get them to the scrub > group. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > tests/btrfs/011 | 2 +- > tests/btrfs/027 | 2 +- > tests/btrfs/060 | 2 +- > tests/btrfs/062 | 2 +- > tests/btrfs/063 | 2 +- > tests/btrfs/064 | 2 +- > tests/btrfs/065 | 2 +- > tests/btrfs/067 | 2 +- > tests/btrfs/068 | 2 +- > tests/btrfs/069 | 2 +- > tests/btrfs/070 | 2 +- > tests/btrfs/071 | 2 +- > tests/btrfs/074 | 2 +- > tests/btrfs/148 | 2 +- > tests/btrfs/195 | 2 +- > tests/btrfs/261 | 2 +- > 16 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/tests/btrfs/011 b/tests/btrfs/011 > index 852742ee8396..ff52ada94a17 100755 > --- a/tests/btrfs/011 > +++ b/tests/btrfs/011 > @@ -20,7 +20,7 @@ > # performed, a btrfsck run, and finally the filesystem is remounted. > # > . ./common/preamble > -_begin_fstest auto replace volume > +_begin_fstest auto replace volume scrub > > noise_pid=0 [snip] > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/069 b/tests/btrfs/069 > index 6e798a2e5061..824ca3c3110b 100755 > --- a/tests/btrfs/069 > +++ b/tests/btrfs/069 > @@ -8,7 +8,7 @@ > # running in background. > # > . ./common/preamble > -_begin_fstest auto replace scrub volume > +_begin_fstest auto replace scrub volume scrub The btrfs/069 has been in "scrub" group, others looks good to me.
On 9/14/23 00:33, Zorro Lang wrote: > On Tue, Aug 29, 2023 at 08:32:40PM +0800, Anand Jain wrote: >> I wanted to verify tests using the command "btrfs scrub start" and >> found that there are many more test cases using "btrfs scrub start" >> than what is listed in the group.list file. So, get them to the scrub >> group. >> >> Signed-off-by: Anand Jain <anand.jain@oracle.com> >> --- >> tests/btrfs/011 | 2 +- >> tests/btrfs/027 | 2 +- >> tests/btrfs/060 | 2 +- >> tests/btrfs/062 | 2 +- >> tests/btrfs/063 | 2 +- >> tests/btrfs/064 | 2 +- >> tests/btrfs/065 | 2 +- >> tests/btrfs/067 | 2 +- >> tests/btrfs/068 | 2 +- >> tests/btrfs/069 | 2 +- >> tests/btrfs/070 | 2 +- >> tests/btrfs/071 | 2 +- >> tests/btrfs/074 | 2 +- >> tests/btrfs/148 | 2 +- >> tests/btrfs/195 | 2 +- >> tests/btrfs/261 | 2 +- >> 16 files changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/tests/btrfs/011 b/tests/btrfs/011 >> index 852742ee8396..ff52ada94a17 100755 >> --- a/tests/btrfs/011 >> +++ b/tests/btrfs/011 >> @@ -20,7 +20,7 @@ >> # performed, a btrfsck run, and finally the filesystem is remounted. >> # >> . ./common/preamble >> -_begin_fstest auto replace volume >> +_begin_fstest auto replace volume scrub >> >> noise_pid=0 > > [snip] > >> # Import common functions. >> . ./common/filter >> diff --git a/tests/btrfs/069 b/tests/btrfs/069 >> index 6e798a2e5061..824ca3c3110b 100755 >> --- a/tests/btrfs/069 >> +++ b/tests/btrfs/069 >> @@ -8,7 +8,7 @@ >> # running in background. >> # >> . ./common/preamble >> -_begin_fstest auto replace scrub volume >> +_begin_fstest auto replace scrub volume scrub > > The btrfs/069 has been in "scrub" group, others looks good to me. > Oh no! Would you please remove this line and merge it? Or, I can fix it in the upcoming PR. Or, I can reroll this patch. Thank you!
On Thu, Sep 14, 2023 at 07:24:57AM +0800, Anand Jain wrote: > > > On 9/14/23 00:33, Zorro Lang wrote: > > On Tue, Aug 29, 2023 at 08:32:40PM +0800, Anand Jain wrote: > > > I wanted to verify tests using the command "btrfs scrub start" and > > > found that there are many more test cases using "btrfs scrub start" > > > than what is listed in the group.list file. So, get them to the scrub > > > group. > > > > > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > > > --- > > > tests/btrfs/011 | 2 +- > > > tests/btrfs/027 | 2 +- > > > tests/btrfs/060 | 2 +- > > > tests/btrfs/062 | 2 +- > > > tests/btrfs/063 | 2 +- > > > tests/btrfs/064 | 2 +- > > > tests/btrfs/065 | 2 +- > > > tests/btrfs/067 | 2 +- > > > tests/btrfs/068 | 2 +- > > > tests/btrfs/069 | 2 +- > > > tests/btrfs/070 | 2 +- > > > tests/btrfs/071 | 2 +- > > > tests/btrfs/074 | 2 +- > > > tests/btrfs/148 | 2 +- > > > tests/btrfs/195 | 2 +- > > > tests/btrfs/261 | 2 +- > > > 16 files changed, 16 insertions(+), 16 deletions(-) > > > > > > diff --git a/tests/btrfs/011 b/tests/btrfs/011 > > > index 852742ee8396..ff52ada94a17 100755 > > > --- a/tests/btrfs/011 > > > +++ b/tests/btrfs/011 > > > @@ -20,7 +20,7 @@ > > > # performed, a btrfsck run, and finally the filesystem is remounted. > > > # > > > . ./common/preamble > > > -_begin_fstest auto replace volume > > > +_begin_fstest auto replace volume scrub > > > noise_pid=0 > > > > [snip] > > > > > # Import common functions. > > > . ./common/filter > > > diff --git a/tests/btrfs/069 b/tests/btrfs/069 > > > index 6e798a2e5061..824ca3c3110b 100755 > > > --- a/tests/btrfs/069 > > > +++ b/tests/btrfs/069 > > > @@ -8,7 +8,7 @@ > > > # running in background. > > > # > > > . ./common/preamble > > > -_begin_fstest auto replace scrub volume > > > +_begin_fstest auto replace scrub volume scrub > > > > The btrfs/069 has been in "scrub" group, others looks good to me. > > > > Oh no! Would you please remove this line and merge it? > Or, I can fix it in the upcoming PR. Or, I can reroll this > patch. > Thank you! I'll remove it when I merge it, don't worry. Thanks, Zorro >
On Tue, Aug 29, 2023 at 08:32:40PM +0800, Anand Jain wrote: > I wanted to verify tests using the command "btrfs scrub start" and > found that there are many more test cases using "btrfs scrub start" > than what is listed in the group.list file. So, get them to the scrub > group. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > tests/btrfs/011 | 2 +- > tests/btrfs/027 | 2 +- > tests/btrfs/060 | 2 +- > tests/btrfs/062 | 2 +- > tests/btrfs/063 | 2 +- > tests/btrfs/064 | 2 +- > tests/btrfs/065 | 2 +- > tests/btrfs/067 | 2 +- > tests/btrfs/068 | 2 +- > tests/btrfs/069 | 2 +- > tests/btrfs/070 | 2 +- > tests/btrfs/071 | 2 +- > tests/btrfs/074 | 2 +- > tests/btrfs/148 | 2 +- > tests/btrfs/195 | 2 +- > tests/btrfs/261 | 2 +- > 16 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/tests/btrfs/011 b/tests/btrfs/011 > index 852742ee8396..ff52ada94a17 100755 > --- a/tests/btrfs/011 > +++ b/tests/btrfs/011 > @@ -20,7 +20,7 @@ > # performed, a btrfsck run, and finally the filesystem is remounted. > # > . ./common/preamble > -_begin_fstest auto replace volume > +_begin_fstest auto replace volume scrub > > noise_pid=0 > > diff --git a/tests/btrfs/027 b/tests/btrfs/027 > index 46c14b9c1c1f..dbf12c26d0cd 100755 > --- a/tests/btrfs/027 > +++ b/tests/btrfs/027 > @@ -7,7 +7,7 @@ > # Test replace of a missing device on various data and metadata profiles. > # > . ./common/preamble > -_begin_fstest auto replace volume > +_begin_fstest auto replace volume scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/060 b/tests/btrfs/060 > index 26db8a9bee20..7dd4d2af74cd 100755 > --- a/tests/btrfs/060 > +++ b/tests/btrfs/060 > @@ -8,7 +8,7 @@ > # with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto balance subvol > +_begin_fstest auto balance subvol scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/062 b/tests/btrfs/062 > index 47b0b9373f33..10f95111f8ff 100755 > --- a/tests/btrfs/062 > +++ b/tests/btrfs/062 > @@ -8,7 +8,7 @@ > # running in background. > # > . ./common/preamble > -_begin_fstest auto balance defrag compress > +_begin_fstest auto balance defrag compress scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/063 b/tests/btrfs/063 > index c96390b9315c..cef80771d457 100755 > --- a/tests/btrfs/063 > +++ b/tests/btrfs/063 > @@ -8,7 +8,7 @@ > # simultaneously, with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto balance remount compress > +_begin_fstest auto balance remount compress scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/064 b/tests/btrfs/064 > index 741161889150..f29e68ba96af 100755 > --- a/tests/btrfs/064 > +++ b/tests/btrfs/064 > @@ -10,7 +10,7 @@ > # run simultaneously. One of them is expected to fail when the other is running. > > . ./common/preamble > -_begin_fstest auto balance replace volume > +_begin_fstest auto balance replace volume scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/065 b/tests/btrfs/065 > index 4ebf93267a59..b6c9dbadfd32 100755 > --- a/tests/btrfs/065 > +++ b/tests/btrfs/065 > @@ -8,7 +8,7 @@ > # operation simultaneously, with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto subvol replace volume > +_begin_fstest auto subvol replace volume scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/067 b/tests/btrfs/067 > index 44803f9faf7f..970a23c470fb 100755 > --- a/tests/btrfs/067 > +++ b/tests/btrfs/067 > @@ -8,7 +8,7 @@ > # operation simultaneously, with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto subvol defrag compress > +_begin_fstest auto subvol defrag compress scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/068 b/tests/btrfs/068 > index e03a4891ec89..e0bcc2ac4930 100755 > --- a/tests/btrfs/068 > +++ b/tests/btrfs/068 > @@ -9,7 +9,7 @@ > # in background. > # > . ./common/preamble > -_begin_fstest auto subvol remount compress > +_begin_fstest auto subvol remount compress scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/069 b/tests/btrfs/069 > index 6e798a2e5061..824ca3c3110b 100755 > --- a/tests/btrfs/069 > +++ b/tests/btrfs/069 > @@ -8,7 +8,7 @@ > # running in background. > # > . ./common/preamble > -_begin_fstest auto replace scrub volume > +_begin_fstest auto replace scrub volume scrub I'll remove this duplicated change when I merge it. So ... Reviewed-by: Zorro Lang <zlang@redhat.com> > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/070 b/tests/btrfs/070 > index dcf978b36b0c..f2e61ad392cd 100755 > --- a/tests/btrfs/070 > +++ b/tests/btrfs/070 > @@ -8,7 +8,7 @@ > # running in background. > # > . ./common/preamble > -_begin_fstest auto replace defrag compress volume > +_begin_fstest auto replace defrag compress volume scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/071 b/tests/btrfs/071 > index cd1de2642a96..40230b112cbc 100755 > --- a/tests/btrfs/071 > +++ b/tests/btrfs/071 > @@ -8,7 +8,7 @@ > # algorithms simultaneously with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto replace remount compress volume > +_begin_fstest auto replace remount compress volume scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/074 b/tests/btrfs/074 > index dc26d8c02497..92e25c7cc24a 100755 > --- a/tests/btrfs/074 > +++ b/tests/btrfs/074 > @@ -8,7 +8,7 @@ > # simultaneously with fsstress running in background. > # > . ./common/preamble > -_begin_fstest auto defrag remount compress > +_begin_fstest auto defrag remount compress scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/148 b/tests/btrfs/148 > index 510e46dc0826..65a262922569 100755 > --- a/tests/btrfs/148 > +++ b/tests/btrfs/148 > @@ -7,7 +7,7 @@ > # Test that direct IO writes work on RAID5 and RAID6 filesystems. > # > . ./common/preamble > -_begin_fstest auto quick rw > +_begin_fstest auto quick rw scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/195 b/tests/btrfs/195 > index 747345973244..96cc41343925 100755 > --- a/tests/btrfs/195 > +++ b/tests/btrfs/195 > @@ -8,7 +8,7 @@ > # source profiles just rely on being able to read the data and metadata. > # > . ./common/preamble > -_begin_fstest auto volume balance > +_begin_fstest auto volume balance scrub > > # Import common functions. > . ./common/filter > diff --git a/tests/btrfs/261 b/tests/btrfs/261 > index 21567052d58e..b33c053fbca0 100755 > --- a/tests/btrfs/261 > +++ b/tests/btrfs/261 > @@ -8,7 +8,7 @@ > # without affecting the consistency of the fs. > # > . ./common/preamble > -_begin_fstest auto volume raid > +_begin_fstest auto volume raid scrub > > _supported_fs btrfs > _require_scratch_dev_pool 4 > -- > 2.39.3 >
diff --git a/tests/btrfs/011 b/tests/btrfs/011 index 852742ee8396..ff52ada94a17 100755 --- a/tests/btrfs/011 +++ b/tests/btrfs/011 @@ -20,7 +20,7 @@ # performed, a btrfsck run, and finally the filesystem is remounted. # . ./common/preamble -_begin_fstest auto replace volume +_begin_fstest auto replace volume scrub noise_pid=0 diff --git a/tests/btrfs/027 b/tests/btrfs/027 index 46c14b9c1c1f..dbf12c26d0cd 100755 --- a/tests/btrfs/027 +++ b/tests/btrfs/027 @@ -7,7 +7,7 @@ # Test replace of a missing device on various data and metadata profiles. # . ./common/preamble -_begin_fstest auto replace volume +_begin_fstest auto replace volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/060 b/tests/btrfs/060 index 26db8a9bee20..7dd4d2af74cd 100755 --- a/tests/btrfs/060 +++ b/tests/btrfs/060 @@ -8,7 +8,7 @@ # with fsstress running in background. # . ./common/preamble -_begin_fstest auto balance subvol +_begin_fstest auto balance subvol scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/062 b/tests/btrfs/062 index 47b0b9373f33..10f95111f8ff 100755 --- a/tests/btrfs/062 +++ b/tests/btrfs/062 @@ -8,7 +8,7 @@ # running in background. # . ./common/preamble -_begin_fstest auto balance defrag compress +_begin_fstest auto balance defrag compress scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/063 b/tests/btrfs/063 index c96390b9315c..cef80771d457 100755 --- a/tests/btrfs/063 +++ b/tests/btrfs/063 @@ -8,7 +8,7 @@ # simultaneously, with fsstress running in background. # . ./common/preamble -_begin_fstest auto balance remount compress +_begin_fstest auto balance remount compress scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/064 b/tests/btrfs/064 index 741161889150..f29e68ba96af 100755 --- a/tests/btrfs/064 +++ b/tests/btrfs/064 @@ -10,7 +10,7 @@ # run simultaneously. One of them is expected to fail when the other is running. . ./common/preamble -_begin_fstest auto balance replace volume +_begin_fstest auto balance replace volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/065 b/tests/btrfs/065 index 4ebf93267a59..b6c9dbadfd32 100755 --- a/tests/btrfs/065 +++ b/tests/btrfs/065 @@ -8,7 +8,7 @@ # operation simultaneously, with fsstress running in background. # . ./common/preamble -_begin_fstest auto subvol replace volume +_begin_fstest auto subvol replace volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/067 b/tests/btrfs/067 index 44803f9faf7f..970a23c470fb 100755 --- a/tests/btrfs/067 +++ b/tests/btrfs/067 @@ -8,7 +8,7 @@ # operation simultaneously, with fsstress running in background. # . ./common/preamble -_begin_fstest auto subvol defrag compress +_begin_fstest auto subvol defrag compress scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/068 b/tests/btrfs/068 index e03a4891ec89..e0bcc2ac4930 100755 --- a/tests/btrfs/068 +++ b/tests/btrfs/068 @@ -9,7 +9,7 @@ # in background. # . ./common/preamble -_begin_fstest auto subvol remount compress +_begin_fstest auto subvol remount compress scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/069 b/tests/btrfs/069 index 6e798a2e5061..824ca3c3110b 100755 --- a/tests/btrfs/069 +++ b/tests/btrfs/069 @@ -8,7 +8,7 @@ # running in background. # . ./common/preamble -_begin_fstest auto replace scrub volume +_begin_fstest auto replace scrub volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/070 b/tests/btrfs/070 index dcf978b36b0c..f2e61ad392cd 100755 --- a/tests/btrfs/070 +++ b/tests/btrfs/070 @@ -8,7 +8,7 @@ # running in background. # . ./common/preamble -_begin_fstest auto replace defrag compress volume +_begin_fstest auto replace defrag compress volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/071 b/tests/btrfs/071 index cd1de2642a96..40230b112cbc 100755 --- a/tests/btrfs/071 +++ b/tests/btrfs/071 @@ -8,7 +8,7 @@ # algorithms simultaneously with fsstress running in background. # . ./common/preamble -_begin_fstest auto replace remount compress volume +_begin_fstest auto replace remount compress volume scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/074 b/tests/btrfs/074 index dc26d8c02497..92e25c7cc24a 100755 --- a/tests/btrfs/074 +++ b/tests/btrfs/074 @@ -8,7 +8,7 @@ # simultaneously with fsstress running in background. # . ./common/preamble -_begin_fstest auto defrag remount compress +_begin_fstest auto defrag remount compress scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/148 b/tests/btrfs/148 index 510e46dc0826..65a262922569 100755 --- a/tests/btrfs/148 +++ b/tests/btrfs/148 @@ -7,7 +7,7 @@ # Test that direct IO writes work on RAID5 and RAID6 filesystems. # . ./common/preamble -_begin_fstest auto quick rw +_begin_fstest auto quick rw scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/195 b/tests/btrfs/195 index 747345973244..96cc41343925 100755 --- a/tests/btrfs/195 +++ b/tests/btrfs/195 @@ -8,7 +8,7 @@ # source profiles just rely on being able to read the data and metadata. # . ./common/preamble -_begin_fstest auto volume balance +_begin_fstest auto volume balance scrub # Import common functions. . ./common/filter diff --git a/tests/btrfs/261 b/tests/btrfs/261 index 21567052d58e..b33c053fbca0 100755 --- a/tests/btrfs/261 +++ b/tests/btrfs/261 @@ -8,7 +8,7 @@ # without affecting the consistency of the fs. # . ./common/preamble -_begin_fstest auto volume raid +_begin_fstest auto volume raid scrub _supported_fs btrfs _require_scratch_dev_pool 4
I wanted to verify tests using the command "btrfs scrub start" and found that there are many more test cases using "btrfs scrub start" than what is listed in the group.list file. So, get them to the scrub group. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- tests/btrfs/011 | 2 +- tests/btrfs/027 | 2 +- tests/btrfs/060 | 2 +- tests/btrfs/062 | 2 +- tests/btrfs/063 | 2 +- tests/btrfs/064 | 2 +- tests/btrfs/065 | 2 +- tests/btrfs/067 | 2 +- tests/btrfs/068 | 2 +- tests/btrfs/069 | 2 +- tests/btrfs/070 | 2 +- tests/btrfs/071 | 2 +- tests/btrfs/074 | 2 +- tests/btrfs/148 | 2 +- tests/btrfs/195 | 2 +- tests/btrfs/261 | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-)