| Message ID | 8dcb7d564180452eec0c2888740c1b0919e171d3.1715108589.git.dsterba@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Move test cased from shared to generic | expand |
On Tue, May 07, 2024 at 09:07:36PM +0200, David Sterba wrote: > The shared/ directory was supposed to host tests that apply to a subset > of all supported filesystems but this is not utilized much and creates a > split from the generic tests. Move the test to generic. > > Signed-off-by: David Sterba <dsterba@suse.com> > --- > tests/{shared/032 => generic/740} | 2 +- > tests/{shared/032.out => generic/740.out} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename tests/{shared/032 => generic/740} (99%) > rename tests/{shared/032.out => generic/740.out} (100%) > > diff --git a/tests/shared/032 b/tests/generic/740 > similarity index 99% > rename from tests/shared/032 > rename to tests/generic/740 > index 131323ab5b0ff8..6ed248617eaa6b 100755 > --- a/tests/shared/032 > +++ b/tests/generic/740 > @@ -2,7 +2,7 @@ > # SPDX-License-Identifier: GPL-2.0 > # Copyright (c) 2000-2002 Silicon Graphics, Inc. All Rights Reserved. > # > -# FS QA Test No. 032 > +# FS QA Test No. 740 > # > # cross check mkfs detection of foreign filesystems > # > diff --git a/tests/shared/032.out b/tests/generic/740.out > similarity index 100% > rename from tests/shared/032.out > rename to tests/generic/740.out Don't you need to update the "QA output created by 032" in 032.out as well? tools/mvtest handles at least the simple cases. --D > -- > 2.44.0 > >
On Tue, May 07, 2024 at 09:07:36PM +0200, David Sterba wrote: > The shared/ directory was supposed to host tests that apply to a subset > of all supported filesystems but this is not utilized much and creates a > split from the generic tests. Move the test to generic. While we're at it, can we please have a _have_mkfs_overwrite detetion instead of hardcoding ext4 and btrfs with another check for that is supported for btrfs? I'm also pretty sure at least ext4 supports overwrite detection as well..
On Wed, May 08, 2024 at 10:40:07PM -0700, Christoph Hellwig wrote: > On Tue, May 07, 2024 at 09:07:36PM +0200, David Sterba wrote: > > The shared/ directory was supposed to host tests that apply to a subset > > of all supported filesystems but this is not utilized much and creates a > > split from the generic tests. Move the test to generic. > > While we're at it, can we please have a > > _have_mkfs_overwrite detetion instead of hardcoding ext4 and btrfs > with another check for that is supported for btrfs? > > I'm also pretty sure at least ext4 supports overwrite detection as > well.. Yeah, that's the reason I still keep the shared as a "prefix directory" of generic. The hardcode whitelist or blacklist of _supported_fs is a bit rude. If a fs isn't supported by a test case totally, that's fine. But if the condition of _notrun can be smaller and more precise (refer to some _require_xxx helpers) that would be great. Of course we can move shared to generic at first, then improve it later. But I doubt if we can keep that in mind, due to there're hundreds of generic cases :) Thanks, Zorro > >
On Thu, May 09, 2024 at 06:00:16PM +0800, Zorro Lang wrote: > Yeah, that's the reason I still keep the shared as a "prefix directory" > of generic. The hardcode whitelist or blacklist of _supported_fs is a > bit rude. If a fs isn't supported by a test case totally, that's fine. > But if the condition of _notrun can be smaller and more precise (refer > to some _require_xxx helpers) that would be great. > > Of course we can move shared to generic at first, then improve it later. > But I doubt if we can keep that in mind, due to there're hundreds of > generic cases :) # git-grep _supported_fs tests/generic/ | grep -v generic will do the job. But before this turns into an endless discussion I can just sign up for adding the proper helpers after the merge is applied.
diff --git a/tests/shared/032 b/tests/generic/740 similarity index 99% rename from tests/shared/032 rename to tests/generic/740 index 131323ab5b0ff8..6ed248617eaa6b 100755 --- a/tests/shared/032 +++ b/tests/generic/740 @@ -2,7 +2,7 @@ # SPDX-License-Identifier: GPL-2.0 # Copyright (c) 2000-2002 Silicon Graphics, Inc. All Rights Reserved. # -# FS QA Test No. 032 +# FS QA Test No. 740 # # cross check mkfs detection of foreign filesystems # diff --git a/tests/shared/032.out b/tests/generic/740.out similarity index 100% rename from tests/shared/032.out rename to tests/generic/740.out
The shared/ directory was supposed to host tests that apply to a subset of all supported filesystems but this is not utilized much and creates a split from the generic tests. Move the test to generic. Signed-off-by: David Sterba <dsterba@suse.com> --- tests/{shared/032 => generic/740} | 2 +- tests/{shared/032.out => generic/740.out} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tests/{shared/032 => generic/740} (99%) rename tests/{shared/032.out => generic/740.out} (100%)