From patchwork Wed Apr 9 07:00:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nirjhar Roy (IBM)" X-Patchwork-Id: 14044173 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2496222D790; Wed, 9 Apr 2025 07:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744182187; cv=none; b=FMFC7n8+INQp/rJ/moTx5fY4l/eTbbqG84/bQVZJ+xBRWqqVqnSDFMOe6bH0Hs0jNp8Vk1mZWeAb3NLwllqVZJ7TLzqXhUMA4JCT4w5ki0LJSkUI38z8UI/VBiB34opHh/WOA4TE2HD9YtW3wYcNN14u901DfX1magS/1Kt2wpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744182187; c=relaxed/simple; bh=ymkrppgv0g7XnTr5ZVxaHyGC4RhQUGO3HjQ4uZBTMYM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KVpUX9YosG39eQvgOJCpCxnBBtQ9lETPd+crYpvtkX0W+qo4Trs+bfPzcNanvFMKQA1rsQBJ/sByit1/splwh35wveF+42WITDZzAPAsZBIZ7iFgtxRsejn+nENhOKG0lXYISHPwgmofDexErk9MLUxFqm++IoJNW38f8LXvyNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fhtz7oPR; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fhtz7oPR" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-224171d6826so91018205ad.3; Wed, 09 Apr 2025 00:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744182185; x=1744786985; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0BMaHmSFaDv5TGbwfxSPV7jt5G6Yz0nXxQMjDs9iO6c=; b=fhtz7oPR0mflcKVXaNCHbDIuLl8UFj/JJh3tFKneg3xUsRNUAhlRVHPDQBomxN7VV6 FCjZfbUBVs5J4iMYQvG2yJl/HxCSKXVg3qH1k2XpXdz0+/jwLWpqr8UNVD7NBcMGy9DG Pl329Y8ec6VnJJxAvuAWsBEi34iXov0xZdUyl/GS7BmbAeGpuinUjoQCqWFaNj5IgT9p k8K6ok6RTvR/0K6uBRZ6MtxzofIzK1tU0RoxwfP39JPY+x2xoBwF/6C+rR22YI6DEVda YrXftSP28a9JTDuzWD7BT1TgkHKfhASpMz4iz1y/Etggonz1ZVkVeabXPHJ9gtSLIWg6 9TcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744182185; x=1744786985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0BMaHmSFaDv5TGbwfxSPV7jt5G6Yz0nXxQMjDs9iO6c=; b=tjMPgGittUj+sONuWQCWqWzpcz2o6DR2gnA5yvNHaHL4Zp+4x9cVznHCnFCWBCglx8 MyKPaWjJiCFI9NhaK0AovF6c2BPXeknxolcGsMRydNgq5X0EmJZDvUGp8qN9+3LYpz3i wncPz3pgHqeK95HHscirRd9c8hESs5/TuU398hoTbmswwtkd+Ce1IuaKHg6XX37hTBfF MfhMpN0edvxZYFrvqnh2IRspckTpbJFRIypJw03D+s19oYxFKKHrZirbCCyTalj0JvrW J6xqPJ0Q78gBUUu8IDsWrOhX53inPQJTuHq4MonAnQGnIbyrDC6dEqoGLe6h4lRm2PaD d6jA== X-Forwarded-Encrypted: i=1; AJvYcCVi+M92mBrnBzXuwhV3z0Zye6IWGYhFlY0qWEiV03M/+XPZMyfzOpBvUZvt91xGGdEU9nzVC14kVi0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpn02YsuXY57pgpAwFX6+u03OdWPGnhFxb3GTXKPm6eYN7Zvlo 6zgE4uBgqrOZSf7yww0JtI/uEInH845KU8+jQ3UW0+6QoIiCGAxooGDmbmRz X-Gm-Gg: ASbGncspXSFsa5lUP0GN9jDMqS/nqdIhBLGmHfh9SJEzvTUHlP4wPDlwwifeaKWBSZz dk3n87InRvWpkZ6cK9sBPoYRQGq0QVOCu5EUcOyDbGDRbT5Hs3DLxjrfL6Q5eLmIEL6HWYAEOwh VSn8/icEptx6QymSVTNoxx7TGWQxizMMrOKpjocUW2pwH5puwHFYEx1uyFuIrD0SnKjNjte9Fki Os8PoQRbIJozJSrvJ6tzHN6OhcjPKYoFzATPKPDme3wblw4GM8NJr6Fs7aQoryY+L3ZPNyS7vcN RaLJ/Fu60LECwHF8KssL3eR2U4PNgcf0iRx9Sl258yo6T2WSwYLUHxg= X-Google-Smtp-Source: AGHT+IEb447HdMKW+LNKFh/utqMiz13P/k5UmbqXcFhFLYYuNTLTsy2ih0nJdeYJfBusNw6MPIimDg== X-Received: by 2002:a17:903:1a67:b0:216:2bd7:1c4a with SMTP id d9443c01a7336-22ac3f9a916mr17345195ad.26.1744182184882; Wed, 09 Apr 2025 00:03:04 -0700 (PDT) Received: from citest-1.. ([122.164.80.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7c939a3sm4491985ad.117.2025.04.09.00.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 00:03:04 -0700 (PDT) From: "Nirjhar Roy (IBM)" To: fstests@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org, david@fromorbit.com, nirjhar.roy.lists@gmail.com Subject: [PATCH v4 3/6] check: Remove redundant _test_mount in check Date: Wed, 9 Apr 2025 07:00:49 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 init_rc already does a _test_mount. Hence removing the additional _test_mount call when OLD_TEST_FS_MOUNT_OPTS != TEST_FS_MOUNT_OPTS. Signed-off-by: Nirjhar Roy (IBM) Reviewed-by: Dave Chinner Reviewed-by: Ritesh Harjani (IBM) Reviewed-by: "Darrick J. Wong" --- check | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/check b/check index 32890470..3d621210 100755 --- a/check +++ b/check @@ -791,13 +791,9 @@ function run_section() . common/rc _prepare_test_list elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then + # Unmount TEST_DEV to apply the updated mount options. + # It will be mounted again by init_rc(), called shortly after. _test_unmount 2> /dev/null - if ! _test_mount - then - echo "check: failed to mount $TEST_DEV on $TEST_DIR" - status=1 - exit - fi fi init_rc