From patchwork Fri Feb 27 03:30:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaolei X-Patchwork-Id: 5897601 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 334B4BF440 for ; Fri, 27 Feb 2015 03:31:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 61F6B201DD for ; Fri, 27 Feb 2015 03:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCAD420218 for ; Fri, 27 Feb 2015 03:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbbB0Dbv (ORCPT ); Thu, 26 Feb 2015 22:31:51 -0500 Received: from cn.fujitsu.com ([59.151.112.132]:19086 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754229AbbB0Dbu (ORCPT ); Thu, 26 Feb 2015 22:31:50 -0500 X-IronPort-AV: E=Sophos;i="5.04,848,1406563200"; d="scan'208";a="58732473" Received: from unknown (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Feb 2015 11:28:10 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t1R3UuvF032638 for ; Fri, 27 Feb 2015 11:30:56 +0800 Received: from localhost.localdomain (10.167.226.114) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Fri, 27 Feb 2015 11:31:52 +0800 From: Zhaolei To: CC: Zhao Lei Subject: [PATCH v2 1/2] xfstests: fix a typo in _require_block_device() Date: Fri, 27 Feb 2015 11:30:35 +0800 Message-ID: X-Mailer: git-send-email 1.8.5.1 MIME-Version: 1.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Zhao Lei We need to check "$1" instead "$SCRATCH_DEV" in this function. Changelog v1->v2: Use tab instead of space to fit new code style. Suggested by: Dave Chinner Reviewed-by: Lukas Czerner Signed-off-by: Zhao Lei --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index 1ed9df5..23193c8 100644 --- a/common/rc +++ b/common/rc @@ -1288,7 +1288,7 @@ _require_block_device() echo "Usage: _require_block_device " 1>&2 exit 1 fi - if [ "`_is_block_dev $SCRATCH_DEV`" == "" ]; then + if [ "`_is_block_dev "$1"`" == "" ]; then _notrun "require $1 to be valid block disk" fi }