diff mbox

exclude dmerror tests with mount -o dax

Message ID b8729f80-6d09-6c57-1fb7-4303558fc9a3@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Sandeen May 19, 2016, 9:12 p.m. UTC 
Same as we do for dm flakey.  dm can't do dax.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jeff Moyer May 20, 2016, 2:41 p.m. UTC | #1 
Eric Sandeen <sandeen@redhat.com> writes:

> Same as we do for dm flakey.  dm can't do dax.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

We'll add support eventually, but for now this makes sense.

Acked-by: Jeff Moyer <jmoyer@redhat.com>

-Jeff

> ---
>
> diff --git a/common/dmerror b/common/dmerror
> index 004530d..42c075e 100644
> --- a/common/dmerror
> +++ b/common/dmerror
> @@ -18,6 +18,11 @@
>  #
>  # common functions for setting up and tearing down a dmerror device
>  
> +echo $MOUNT_OPTIONS | grep -q dax
> +if [ $? -eq 0 ]; then
> +	_notrun "Cannot run tests with DAX on dmerror devices"
> +fi
> +
>  _dmerror_init()
>  {
>  	local dm_backing_dev=$SCRATCH_DEV
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig May 23, 2016, 2:59 p.m. UTC | #2 
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/dmerror b/common/dmerror
index 004530d..42c075e 100644
--- a/common/dmerror
+++ b/common/dmerror
@@ -18,6 +18,11 @@ 
 #
 # common functions for setting up and tearing down a dmerror device
 
+echo $MOUNT_OPTIONS | grep -q dax
+if [ $? -eq 0 ]; then
+	_notrun "Cannot run tests with DAX on dmerror devices"
+fi
+
 _dmerror_init()
 {
 	local dm_backing_dev=$SCRATCH_DEV