From patchwork Thu Mar 22 20:09:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Sandeen X-Patchwork-Id: 10302209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 867BB60386 for ; Thu, 22 Mar 2018 20:09:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74D2A28962 for ; Thu, 22 Mar 2018 20:09:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6805E2896A; Thu, 22 Mar 2018 20:09:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0400E28962 for ; Thu, 22 Mar 2018 20:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbeCVUJz (ORCPT ); Thu, 22 Mar 2018 16:09:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57816 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbeCVUJz (ORCPT ); Thu, 22 Mar 2018 16:09:55 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 111FAC04BD38 for ; Thu, 22 Mar 2018 20:09:55 +0000 (UTC) Received: from [IPv6:::1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C6F6D5D757 for ; Thu, 22 Mar 2018 20:09:54 +0000 (UTC) To: fstests From: Eric Sandeen Subject: [PATCH] xfs/278: mkfs with v4 format Message-ID: Date: Thu, 22 Mar 2018 15:09:53 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 22 Mar 2018 20:09:55 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This test had silently stopped working when mkfs.xfs switched to v5 supers by default, and changed inode sizes: > field u not found > parsing error > field u not found > parsing error ... Switch back to the original behavior by turning off crcs, and catch such failures if they crop up again by looking for xfs_db errors in $seqres.full. Signed-off-by: Eric Sandeen --- (is it horrific to grep $seqres.full? xfs_db doesn't exit with failure in this case :( ) and now this causes repair to fail on a verifier error, but I just sent an xfsprogs patch to fix that as well. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/xfs/278 b/tests/xfs/278 index b94ee9c..c0e09c7 100755 --- a/tests/xfs/278 +++ b/tests/xfs/278 @@ -48,7 +48,7 @@ _supported_os Linux _require_scratch rm -f $seqres.full -_scratch_mkfs >$seqres.full 2>&1 +_scratch_mkfs -m crc=0 -n ftype=0 >$seqres.full 2>&1 _scratch_mount mkdir -p $SCRATCH_MNT/dir/subdir @@ -73,6 +73,8 @@ _scratch_xfs_db -x -c "inode $DIR_INO" -c "write core.nlinkv2 0" >> $seqres.ful _scratch_xfs_db -x -c "inode $SUBDIR_INO" -c "write u.sfdir2.hdr.parent.i4 0" >> $seqres.full _scratch_xfs_db -x -c "inode $SUBDIR_INO" -c "write core.nlinkv2 0" >> $seqres.full +grep -q "not found\|parsing error" $seqres.full && _fail "xfs_db commands failed" + echo "===== BEGIN of xfs_repair =====" >> $seqres.full echo "" >>$seqres.full