diff mbox

statx: correct error handling of NULL pathname

Message ID d10d318c-7461-96fb-952b-c246811a8228@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Michael Kerrisk (man-pages) April 27, 2017, 11:54 a.m. UTC 
The change in 1e2f82d1e9d1 to error on a NULL pathname to statx()
is inconsistent.  It results in the error EINVAL for a NULL pathname.
Consistent with similar APIs (fchownat(), fstatat(), linkat()),
the error should be EFAULT.

The solution is simply to remove the EINVAL check. As I already
pointed out in https://lkml.org/lkml/2017/4/26/561, user_path_at*()
and filename_lookup() will handle the NULL pathname as per
the other APIs, to correctly produce the error EFAULT.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
---
 fs/stat.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox

Patch

diff --git a/fs/stat.c b/fs/stat.c
index 3d85747..a257b87 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -567,8 +567,6 @@  SYSCALL_DEFINE5(statx,
 		return -EINVAL;
 	if ((flags & AT_STATX_SYNC_TYPE) == AT_STATX_SYNC_TYPE)
 		return -EINVAL;
-	if (!filename)
-		return -EINVAL;
 
 	error = vfs_statx(dfd, filename, flags, &stat, mask);
 	if (error)