From patchwork Wed Jan 25 16:44:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 9537459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AAA0B6046A for ; Wed, 25 Jan 2017 16:44:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B32C27D85 for ; Wed, 25 Jan 2017 16:44:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8FBB62817F; Wed, 25 Jan 2017 16:44:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DB3427D85 for ; Wed, 25 Jan 2017 16:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdAYQog (ORCPT ); Wed, 25 Jan 2017 11:44:36 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35179 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbdAYQof (ORCPT ); Wed, 25 Jan 2017 11:44:35 -0500 Received: by mail-pf0-f177.google.com with SMTP id f144so59394274pfa.2 for ; Wed, 25 Jan 2017 08:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Dx8bNkdWJBfsaqVwZIYSh5g2zMjp5XnN3fBJTbiVhqs=; b=RhnfZTp9bcAZMhyrpv2jI36vzQsbwlxFBzBHlw3JMcPYn5CC/xfqtoXgGrK3ZXgEdC GCsOffH3RVf/2iyVOrgqCVt5ghEZ2d5qC7UEaBZHQXaVu6duk+YsB+hrTpKP+cXxaSwE xKjvzDD4HkFRpofcHRG0klDkxyP5Ubeh+bm5T0FTm72BPA7ylT6z5GkcOz5UQLsDShjY h0qEmnS6JyNKfoVKZo4goSA8ClW3BK3ZZ27WSDNZ7HFBeqpzcs5JEUg8ujzBHJimGiAS 3zqXKEUQRDB01TiCDsIWat5f1JgqKi2i4FPLMV/NXauYkZDKh5FyZ0NahfUtNAV8vhzg Q6RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Dx8bNkdWJBfsaqVwZIYSh5g2zMjp5XnN3fBJTbiVhqs=; b=QDYM7msS8ozKcdHatGPIyYhZO7lgNfkc9ukivQNawE1g2luFM39T/ri7T2YZWTG7hN +jLhjlgEmztfBIzy3NOJzpQpAhLOTNM5tyLvdC7BSWEVEUD6AuDvg1FvrTuLjQD4jAH/ Gw5hPVYbH2PapC4q9CskK8qAKc0HtBQI8kj7k7crHKzGkGC68oSeGBly31nQOv61GfsG nIdymZvAYMiqcP0w2cW2WYu2uKylMiQCotvh3fTEmGOKhgQj1elWw8kkbLCe52mQaEdB 8jk45Xp5yG03M9Ky7J6az+wY2pIcNxemlEltHXh6Fsgq1JWEfDOG8iFbF1fBTPO/plfm y94Q== X-Gm-Message-State: AIkVDXJ4nVzVca3ekyYRKfrO9lxO88klk611WjWg7gKdmae/9AAbY2tWSYjxHzcdl6+uGlX9 X-Received: by 10.84.143.203 with SMTP id 69mr5039343plz.68.1485362674461; Wed, 25 Jan 2017 08:44:34 -0800 (PST) Received: from localhost.localdomain ([2601:602:8801:8110:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id s65sm2404744pgb.25.2017.01.25.08.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2017 08:44:34 -0800 (PST) From: Omar Sandoval To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v2] btrfs: add regression test for setxattr on subvolume directory Date: Wed, 25 Jan 2017 08:44:01 -0800 Message-Id: X-Mailer: git-send-email 2.11.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Omar Sandoval This is a regression test for "Btrfs: disable xattr operations on subvolume directories". On v4.9, it will result in an aborted transaction. Reviewed-by: Anand Jain Signed-off-by: Omar Sandoval --- Changes since v1: fix executable permissions, use $BTRFS_UTIL_PROG, add Anand's Reviewed-by. tests/btrfs/047 | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/047.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 72 insertions(+) create mode 100755 tests/btrfs/047 create mode 100644 tests/btrfs/047.out diff --git a/tests/btrfs/047 b/tests/btrfs/047 new file mode 100755 index 00000000..411f1aff --- /dev/null +++ b/tests/btrfs/047 @@ -0,0 +1,69 @@ +#! /bin/bash +# FS QA Test 047 +# +# Test that we can't set xattrs on subvolume placeholder directories. +# Regression test for Btrfs: disable xattr operations on subvolume directories. +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Facebook. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/attr + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs btrfs +_supported_os Linux +_require_attrs +_require_scratch + +_scratch_mkfs >/dev/null 2>&1 +_scratch_mount + +$BTRFS_UTIL_PROG subvolume create "$SCRATCH_MNT/parent" >>$seqres.full +$BTRFS_UTIL_PROG subvolume create "$SCRATCH_MNT/parent/child" >>$seqres.full +$BTRFS_UTIL_PROG subvolume snapshot "$SCRATCH_MNT/parent" "$SCRATCH_MNT/snapshot" >>$seqres.full + +$SETFATTR_PROG -n user.test -v foo "$SCRATCH_MNT/snapshot/child" |& _filter_scratch + +# The original bug resulted in bogus delayed inodes being inserted, so run the +# delayed inodes by doing a commit. +$BTRFS_UTIL_PROG filesystem sync "$SCRATCH_MNT" >>$seqres.full + +status=0 +exit diff --git a/tests/btrfs/047.out b/tests/btrfs/047.out new file mode 100644 index 00000000..48555e90 --- /dev/null +++ b/tests/btrfs/047.out @@ -0,0 +1,2 @@ +QA output created by 047 +setfattr: SCRATCH_MNT/snapshot/child: Operation not supported diff --git a/tests/btrfs/group b/tests/btrfs/group index 88fb8db4..69451c6b 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -49,6 +49,7 @@ 044 auto quick send 045 auto quick send 046 auto quick send +047 auto quick snapshot attr 048 auto quick 049 auto quick 050 auto quick send