From patchwork Wed Jul 22 04:32:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaolei X-Patchwork-Id: 6839351 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 76C979F38B for ; Wed, 22 Jul 2015 04:34:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 90D63205B7 for ; Wed, 22 Jul 2015 04:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88DB3204E4 for ; Wed, 22 Jul 2015 04:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752271AbbGVEeS (ORCPT ); Wed, 22 Jul 2015 00:34:18 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:29047 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751836AbbGVEeS (ORCPT ); Wed, 22 Jul 2015 00:34:18 -0400 X-IronPort-AV: E=Sophos;i="5.15,520,1432569600"; d="scan'208";a="98708666" Received: from bogon (HELO edo.cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 22 Jul 2015 12:37:55 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (localhost.localdomain [127.0.0.1]) by edo.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id t6M4WPvh012279 for ; Wed, 22 Jul 2015 12:32:25 +0800 Received: from localhost.localdomain (10.167.226.114) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Wed, 22 Jul 2015 12:34:13 +0800 From: Zhaolei To: CC: Zhao Lei Subject: [PATCH] Make -g and -x option meet description in manual Date: Wed, 22 Jul 2015 12:32:37 +0800 Message-ID: X-Mailer: git-send-email 1.8.5.1 MIME-Version: 1.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Zhao Lei In manual: # ./check --help ... -g group[,group...] include tests from these groups -x group[,group...] exclude tests from these groups ... Above format is not supported, because ',' is not parsed in code. This patch fixed it. Before patch: # ./check -g scrub,replace Group "scrub,replace" is empty or not defined? After patch: # ./check -g scrub,replace FSTYP -- btrfs PLATFORM -- Linux/x86_64 kerneldev 4.2.0-rc2_HEAD_c65b99f046843d2455aa231747b5a07a999a9f3d_+ MKFS_OPTIONS -- /dev/vdd MOUNT_OPTIONS -- /dev/vdd /var/ltf/tester/scratch_mnt ...(right result)... Signed-off-by: Zhao Lei Reviewed-by: Eryu Guan --- check | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check b/check index a300130..330c3e8 100755 --- a/check +++ b/check @@ -209,11 +209,11 @@ while [ $# -gt 0 ]; do -tmpfs) FSTYP=tmpfs ;; -g) group=$2 ; shift ; - GROUP_LIST="$GROUP_LIST $group" + GROUP_LIST="$GROUP_LIST ${group//,/ }" ;; -x) xgroup=$2 ; shift ; - XGROUP_LIST="$XGROUP_LIST $xgroup" + XGROUP_LIST="$XGROUP_LIST ${xgroup//,/ }" ;; -X) xfile=$2; shift ;