| Message ID | faeda97208d0a2ecca94490b35a4dc8e98e7fdc6.1708772619.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: functional test cases for tempfsid | expand |
On Sat, Feb 24, 2024 at 4:44 PM Anand Jain <anand.jain@oracle.com> wrote: > > Make sure that basic functions such as seeding and device add fail, > while balance runs successfully with tempfsid. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > v3: > Comment updated. > Add balance group. > Drop prerequisite checks. > Use error (from subvol create) in the golden output instead of calling _fail. > > v2: > Remove unnecessary function. > Add clone group > use $UMOUNT_PROG > Let _cp_reflink fail on the stdout. > > tests/btrfs/315 | 78 +++++++++++++++++++++++++++++++++++++++++++++ > tests/btrfs/315.out | 10 ++++++ > 2 files changed, 88 insertions(+) > create mode 100755 tests/btrfs/315 > create mode 100644 tests/btrfs/315.out > > diff --git a/tests/btrfs/315 b/tests/btrfs/315 > new file mode 100755 > index 000000000000..696e26fe339c > --- /dev/null > +++ b/tests/btrfs/315 > @@ -0,0 +1,78 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2024 Oracle. All Rights Reserved. > +# > +# FS QA Test 315 > +# > +# Verify if the seed and device add to a tempfsid filesystem fails > +# and balance devices is successful. > +# > +. ./common/preamble > +_begin_fstest auto quick volume seed balance tempfsid > + > +_cleanup() > +{ > + cd / > + $UMOUNT_PROG $tempfsid_mnt 2>/dev/null > + rm -r -f $tmp.* > + rm -r -f $tempfsid_mnt > +} > + > +. ./common/filter.btrfs > + > +_supported_fs btrfs > +_require_btrfs_sysfs_fsid Same as in the previous test case. This requirement is not needed, the sysfs fsid path is not used anywhere in this test, likely copy-pasted from previous test cases in this patchset. Thanks. > +_require_scratch_dev_pool 3 > +_require_btrfs_fs_feature temp_fsid > + > +_scratch_dev_pool_get 3 > + > +# mount point for the tempfsid device > +tempfsid_mnt=$TEST_DIR/$seq/tempfsid_mnt > + > +seed_device_must_fail() > +{ > + echo ---- $FUNCNAME ---- > + > + mkfs_clone ${SCRATCH_DEV} ${SCRATCH_DEV_NAME[1]} > + > + $BTRFS_TUNE_PROG -S 1 ${SCRATCH_DEV} > + $BTRFS_TUNE_PROG -S 1 ${SCRATCH_DEV_NAME[1]} > + > + _scratch_mount 2>&1 | _filter_scratch > + _mount ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt} 2>&1 | _filter_test_dir > +} > + > +device_add_must_fail() > +{ > + echo ---- $FUNCNAME ---- > + > + mkfs_clone ${SCRATCH_DEV} ${SCRATCH_DEV_NAME[1]} > + _scratch_mount > + _mount ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt} > + > + $XFS_IO_PROG -fc 'pwrite -S 0x61 0 9000' $SCRATCH_MNT/foo | \ > + _filter_xfs_io > + > +$BTRFS_UTIL_PROG device add -f ${SCRATCH_DEV_NAME[2]} ${tempfsid_mnt} 2>&1 | \ > + grep -v "Performing full device TRIM" | _filter_scratch_pool > + > + echo Balance must be successful > + _run_btrfs_balance_start ${tempfsid_mnt} > +} > + > +mkdir -p $tempfsid_mnt > + > +seed_device_must_fail > + > +_scratch_unmount > +_cleanup > +mkdir -p $tempfsid_mnt > + > +device_add_must_fail > + > +_scratch_dev_pool_put > + > +# success, all done > +status=0 > +exit > diff --git a/tests/btrfs/315.out b/tests/btrfs/315.out > new file mode 100644 > index 000000000000..56301f9f069e > --- /dev/null > +++ b/tests/btrfs/315.out > @@ -0,0 +1,10 @@ > +QA output created by 315 > +---- seed_device_must_fail ---- > +mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only. > +mount: TEST_DIR/315/tempfsid_mnt: mount(2) system call failed: File exists. > +---- device_add_must_fail ---- > +wrote 9000/9000 bytes at offset 0 > +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +ERROR: error adding device 'SCRATCH_DEV': Invalid argument > +Balance must be successful > +Done, had to relocate 3 out of 3 chunks > -- > 2.39.3 >
>> +_require_btrfs_sysfs_fsid > > Same as in the previous test case. This requirement is not needed, the > sysfs fsid path is not used anywhere in this test, likely copy-pasted > from previous test cases in this patchset. > Yep. Replaced with "_require_btrfs_fs_feature temp_fsid" >> diff --git a/tests/btrfs/315.out b/tests/btrfs/315.out >> new file mode 100644 >> index 000000000000..56301f9f069e >> --- /dev/null >> +++ b/tests/btrfs/315.out >> @@ -0,0 +1,10 @@ >> +QA output created by 315 >> +---- seed_device_must_fail ---- >> +mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only. >> +mount: TEST_DIR/315/tempfsid_mnt: mount(2) system call failed: File exists. The error output has changed due to some external fixes. V4 contains changes accordingly. Old: mount: <mnt-point>: mount(2) system call failed: File exists. New: mount: <mnt-point>: fsconfig system call failed: File exists. dmesg(1) may have more information after failed mount system call. Thanks, Anand
diff --git a/tests/btrfs/315 b/tests/btrfs/315 new file mode 100755 index 000000000000..696e26fe339c --- /dev/null +++ b/tests/btrfs/315 @@ -0,0 +1,78 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2024 Oracle. All Rights Reserved. +# +# FS QA Test 315 +# +# Verify if the seed and device add to a tempfsid filesystem fails +# and balance devices is successful. +# +. ./common/preamble +_begin_fstest auto quick volume seed balance tempfsid + +_cleanup() +{ + cd / + $UMOUNT_PROG $tempfsid_mnt 2>/dev/null + rm -r -f $tmp.* + rm -r -f $tempfsid_mnt +} + +. ./common/filter.btrfs + +_supported_fs btrfs +_require_btrfs_sysfs_fsid +_require_scratch_dev_pool 3 +_require_btrfs_fs_feature temp_fsid + +_scratch_dev_pool_get 3 + +# mount point for the tempfsid device +tempfsid_mnt=$TEST_DIR/$seq/tempfsid_mnt + +seed_device_must_fail() +{ + echo ---- $FUNCNAME ---- + + mkfs_clone ${SCRATCH_DEV} ${SCRATCH_DEV_NAME[1]} + + $BTRFS_TUNE_PROG -S 1 ${SCRATCH_DEV} + $BTRFS_TUNE_PROG -S 1 ${SCRATCH_DEV_NAME[1]} + + _scratch_mount 2>&1 | _filter_scratch + _mount ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt} 2>&1 | _filter_test_dir +} + +device_add_must_fail() +{ + echo ---- $FUNCNAME ---- + + mkfs_clone ${SCRATCH_DEV} ${SCRATCH_DEV_NAME[1]} + _scratch_mount + _mount ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt} + + $XFS_IO_PROG -fc 'pwrite -S 0x61 0 9000' $SCRATCH_MNT/foo | \ + _filter_xfs_io + +$BTRFS_UTIL_PROG device add -f ${SCRATCH_DEV_NAME[2]} ${tempfsid_mnt} 2>&1 | \ + grep -v "Performing full device TRIM" | _filter_scratch_pool + + echo Balance must be successful + _run_btrfs_balance_start ${tempfsid_mnt} +} + +mkdir -p $tempfsid_mnt + +seed_device_must_fail + +_scratch_unmount +_cleanup +mkdir -p $tempfsid_mnt + +device_add_must_fail + +_scratch_dev_pool_put + +# success, all done +status=0 +exit diff --git a/tests/btrfs/315.out b/tests/btrfs/315.out new file mode 100644 index 000000000000..56301f9f069e --- /dev/null +++ b/tests/btrfs/315.out @@ -0,0 +1,10 @@ +QA output created by 315 +---- seed_device_must_fail ---- +mount: SCRATCH_MNT: WARNING: source write-protected, mounted read-only. +mount: TEST_DIR/315/tempfsid_mnt: mount(2) system call failed: File exists. +---- device_add_must_fail ---- +wrote 9000/9000 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +ERROR: error adding device 'SCRATCH_DEV': Invalid argument +Balance must be successful +Done, had to relocate 3 out of 3 chunks
Make sure that basic functions such as seeding and device add fail, while balance runs successfully with tempfsid. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- v3: Comment updated. Add balance group. Drop prerequisite checks. Use error (from subvol create) in the golden output instead of calling _fail. v2: Remove unnecessary function. Add clone group use $UMOUNT_PROG Let _cp_reflink fail on the stdout. tests/btrfs/315 | 78 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/315.out | 10 ++++++ 2 files changed, 88 insertions(+) create mode 100755 tests/btrfs/315 create mode 100644 tests/btrfs/315.out