[23/38] xfs_db: dump merkle tree data

Message ID	171444683465.960383.2818025551403654518.stgit@frogsfrogsfrogs (mailing list archive)
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263BD111A2; Tue, 30 Apr 2024 03:36:53 +0000 (UTC) Date: Mon, 29 Apr 2024 20:36:53 -0700 Subject: [PATCH 23/38] xfs_db: dump merkle tree data From: "Darrick J. Wong" <djwong@kernel.org> To: aalbersh@redhat.com, ebiggers@kernel.org, cem@kernel.org, djwong@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, fsverity@lists.linux.dev Message-ID: <171444683465.960383.2818025551403654518.stgit@frogsfrogsfrogs> In-Reply-To: <171444683053.960383.12871831441554683674.stgit@frogsfrogsfrogs> References: <171444683053.960383.12871831441554683674.stgit@frogsfrogsfrogs> User-Agent: StGit/0.19 Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit
Series	[01/38] fs: add FS_XFLAG_VERITY for verity files \| expand [01/38] fs: add FS_XFLAG_VERITY for verity files [02/38] xfs: use unsigned ints for non-negative quantities in xfs_attr_remote.c [03/38] xfs: turn XFS_ATTR3_RMT_BUF_SPACE into a function [04/38] xfs: create a helper to compute the blockcount of a max sized remote value [05/38] xfs: minor cleanups of xfs_attr3_rmt_blocks [06/38] xfs: use an empty transaction to protect xfs_attr_get from deadlocks [07/38] xfs: add attribute type for fs-verity [08/38] xfs: do not use xfs_attr3_rmt_hdr for remote verity value blocks [09/38] xfs: add fs-verity ro-compat flag [10/38] xfs: add inode on-disk VERITY flag [11/38] xfs: add fs-verity support [12/38] xfs: use merkle tree offset as attr hash [13/38] xfs: advertise fs-verity being available on filesystem [14/38] xfs: report verity failures through the health system [15/38] xfs: enable ro-compat fs-verity flag [16/38] libfrog: add fsverity to xfs_report_geom output [17/38] xfs_db: introduce attr_modify command [18/38] xfs_db: add ATTR_PARENT support to attr_modify command [19/38] xfs_db: make attr_set/remove/modify be able to handle fs-verity attrs [20/38] man: document attr_modify command [21/38] xfs_db: create hex string as a field type [22/38] xfs_db: dump verity features and metadata [23/38] xfs_db: dump merkle tree data [24/38] xfs_db: dump the verity descriptor [25/38] xfs_db: don't obfuscate verity xattrs [26/38] xfs_db: dump the inode verity flag [27/38] xfs_db: compute hashes of merkle tree blocks [28/38] xfs_repair: junk fsverity xattrs when unnecessary [29/38] xfs_repair: clear verity iflag when verity isn't supported [30/38] xfs_repair: handle verity remote attrs [31/38] xfs_repair: allow upgrading filesystems with verity [32/38] xfs_scrub: check verity file metadata [33/38] xfs_scrub: validate verity file contents when doing a media scan [34/38] xfs_scrub: use MADV_POPULATE_READ to check verity files [35/38] xfs_spaceman: report data corruption [36/38] xfs_io: report fsverity status via statx [37/38] xfs_io: create magic command to disable verity [38/38] mkfs.xfs: add verity parameter

diff --git a/db/attr.c b/db/attr.c index 8e2bce7b7e02..7d8bdeb53032 100644 --- a/db/attr.c +++ b/db/attr.c @@ -35,6 +35,12 @@ static int attr3_remote_data_count(void *obj, int startoff); static int attr_leaf_value_pptr_count(void *obj, int startoff); +static bool is_verity_file(void); +static int attr3_remote_merkledata_count(void *obj, int startoff); +static int attr_leaf_name_local_merkledata_count(void *obj, int startoff); +static int attr_leaf_name_local_merkleoff_count(void *obj, int startoff); +static int attr_leaf_name_remote_merkleoff_count(void *obj, int startoff); + const field_t attr_hfld[] = { { "", FLDT_ATTR, OI(0), C1, 0, TYP_NONE }, { NULL } @@ -87,6 +93,9 @@ const field_t attr_leaf_entry_flds[] = { { "parent", FLDT_UINT1, OI(LEOFF(flags) + bitsz(uint8_t) - XFS_ATTR_PARENT_BIT - 1), C1, 0, TYP_NONE }, + { "verity", FLDT_UINT1, + OI(LEOFF(flags) + bitsz(uint8_t) - XFS_ATTR_VERITY_BIT - 1), C1, 0, + TYP_NONE }, { "pad2", FLDT_UINT8X, OI(LEOFF(pad2)), C1, FLD_SKIPALL, TYP_NONE }, { NULL } }; @@ -113,6 +122,10 @@ const field_t attr_leaf_map_flds[] = { #define LNOFF(f) bitize(offsetof(xfs_attr_leaf_name_local_t, f)) #define LVOFF(f) bitize(offsetof(xfs_attr_leaf_name_remote_t, f)) +#define MKLOFF(f) bitize(offsetof(xfs_attr_leaf_name_local_t, nameval) + \ + offsetof(struct xfs_merkle_key, f)) +#define MKROFF(f) bitize(offsetof(xfs_attr_leaf_name_remote_t, name) + \ + offsetof(struct xfs_merkle_key, f)) const field_t attr_leaf_name_flds[] = { { "valuelen", FLDT_UINT16D, OI(LNOFF(valuelen)), attr_leaf_name_local_count, FLD_COUNT, TYP_NONE }, @@ -122,8 +135,12 @@ const field_t attr_leaf_name_flds[] = { attr_leaf_name_local_name_count, FLD_COUNT, TYP_NONE }, { "parent_dir", FLDT_PARENT_REC, attr_leaf_name_local_value_offset, attr_leaf_value_pptr_count, FLD_COUNT | FLD_OFFSET, TYP_NONE }, + { "merkle_pos", FLDT_UINT64X, OI(MKLOFF(mk_pos)), + attr_leaf_name_local_merkleoff_count, FLD_COUNT, TYP_NONE }, { "value", FLDT_CHARNS, attr_leaf_name_local_value_offset, attr_leaf_name_local_value_count, FLD_COUNT|FLD_OFFSET, TYP_NONE }, + { "merkle_data", FLDT_HEXSTRING, attr_leaf_name_local_value_offset, + attr_leaf_name_local_merkledata_count, FLD_COUNT|FLD_OFFSET, TYP_NONE }, { "valueblk", FLDT_UINT32X, OI(LVOFF(valueblk)), attr_leaf_name_remote_count, FLD_COUNT, TYP_NONE }, { "valuelen", FLDT_UINT32D, OI(LVOFF(valuelen)), @@ -132,6 +149,8 @@ const field_t attr_leaf_name_flds[] = { attr_leaf_name_remote_count, FLD_COUNT, TYP_NONE }, { "name", FLDT_CHARNS, OI(LVOFF(name)), attr_leaf_name_remote_name_count, FLD_COUNT, TYP_NONE }, + { "merkle_pos", FLDT_UINT64X, OI(MKROFF(mk_pos)), + attr_leaf_name_remote_merkleoff_count, FLD_COUNT, TYP_NONE }, { NULL } }; @@ -265,7 +284,19 @@ __attr_leaf_name_local_count( struct xfs_attr_leaf_entry *e, int i) { - return (e->flags & XFS_ATTR_LOCAL) != 0; + struct xfs_attr_leaf_name_local *l; + + if (!(e->flags & XFS_ATTR_LOCAL)) + return 0; + + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY) { + l = xfs_attr3_leaf_name_local(leaf, i); + + if (l->namelen == sizeof(struct xfs_merkle_key)) + return 0; + } + + return 1; } static int @@ -289,6 +320,10 @@ __attr_leaf_name_local_name_count( return 0; l = xfs_attr3_leaf_name_local(leaf, i); + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY && + l->namelen == sizeof(struct xfs_merkle_key)) + return 0; + return l->namelen; } @@ -311,7 +346,8 @@ __attr_leaf_name_local_value_count( if (!(e->flags & XFS_ATTR_LOCAL)) return 0; - if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_PARENT) + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_PARENT || + (e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY) return 0; l = xfs_attr3_leaf_name_local(leaf, i); @@ -382,6 +418,10 @@ __attr_leaf_name_remote_name_count( return 0; r = xfs_attr3_leaf_name_remote(leaf, i); + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY && + r->namelen == sizeof(struct xfs_merkle_key)) + return 0; + return r->namelen; } @@ -542,6 +582,141 @@ attr_leaf_value_pptr_count( return attr_leaf_entry_walk(obj, startoff, __leaf_pptr_count); } +/* + * Is the current file a verity file? This is a kludge for handling merkle + * tree blocks stored in a XFS_ATTR_VERITY attr's remote value block because we + * can't access the leaf entry to find out if the attr is actually a verity + * attr. + */ +static bool +is_verity_file(void) +{ + struct xfs_inode *ip; + bool ret = false; + + if (iocur_top->ino == 0 || iocur_top->ino == NULLFSINO) + return false; + + if (!xfs_has_verity(mp)) + return false; + + ret = -libxfs_iget(mp, NULL, iocur_top->ino, 0, &ip); + if (ret) + return false; + + if (ip->i_diflags2 & XFS_DIFLAG2_VERITY) + ret = true; + + libxfs_irele(ip); + return ret; +} + +static int +attr3_remote_merkledata_count( + void *obj, + int startoff) +{ + struct xfs_attr3_leaf_hdr *lhdr = obj; + struct xfs_attr3_rmt_hdr *rhdr = obj; + + if (rhdr->rm_magic == cpu_to_be32(XFS_ATTR3_RMT_MAGIC) || + lhdr->info.hdr.magic == cpu_to_be16(XFS_DA_NODE_MAGIC) || + lhdr->info.hdr.magic == cpu_to_be16(XFS_DA3_NODE_MAGIC) || + lhdr->info.hdr.magic == cpu_to_be16(XFS_ATTR_LEAF_MAGIC) || + lhdr->info.hdr.magic == cpu_to_be16(XFS_ATTR3_LEAF_MAGIC)) + return 0; + + if (startoff != 0 || !is_verity_file()) + return 0; + + return mp->m_sb.sb_blocksize; +} + +static int +__leaf_local_merkledata_count( + struct xfs_attr_leafblock *leaf, + struct xfs_attr_leaf_entry *e, + int i) +{ + struct xfs_attr_leaf_name_local *l; + + if (!(e->flags & XFS_ATTR_LOCAL)) + return 0; + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_PARENT) + return 0; + + l = xfs_attr3_leaf_name_local(leaf, i); + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY && + l->namelen == sizeof(struct xfs_merkle_key)) + return be16_to_cpu(l->valuelen); + + return 0; +} + +static int +attr_leaf_name_local_merkledata_count( + void *obj, + int startoff) +{ + return attr_leaf_entry_walk(obj, startoff, __leaf_local_merkledata_count); +} + +static int +__leaf_local_merkleoff_count( + struct xfs_attr_leafblock *leaf, + struct xfs_attr_leaf_entry *e, + int i) +{ + struct xfs_attr_leaf_name_local *l; + + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) != XFS_ATTR_VERITY) + return 0; + if (!(e->flags & XFS_ATTR_LOCAL)) + return 0; + + l = xfs_attr3_leaf_name_local(leaf, i); + if (l->namelen != sizeof(struct xfs_merkle_key)) + return 0; + + return 1; +} + +static int +attr_leaf_name_local_merkleoff_count( + void *obj, + int startoff) +{ + return attr_leaf_entry_walk(obj, startoff, __leaf_local_merkleoff_count); +} + +static int +__leaf_remote_merkleoff_count( + struct xfs_attr_leafblock *leaf, + struct xfs_attr_leaf_entry *e, + int i) +{ + struct xfs_attr_leaf_name_remote *r; + + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) != XFS_ATTR_VERITY) + return 0; + if (e->flags & XFS_ATTR_LOCAL) + return 0; + + r = xfs_attr3_leaf_name_remote(leaf, i); + if (r->namelen != sizeof(struct xfs_merkle_key)) + return 0; + + return 1; +} + +static int +attr_leaf_name_remote_merkleoff_count( + void *obj, + int startoff) +{ + return attr_leaf_entry_walk(obj, startoff, __leaf_remote_merkleoff_count); +} + int attr_size( void *obj, @@ -570,6 +745,8 @@ const field_t attr3_flds[] = { FLD_COUNT, TYP_NONE }, { "data", FLDT_CHARNS, OI(bitize(sizeof(struct xfs_attr3_rmt_hdr))), attr3_remote_data_count, FLD_COUNT, TYP_NONE }, + { "merkle_data", FLDT_HEXSTRING, OI(0), + attr3_remote_merkledata_count, FLD_COUNT, TYP_NONE }, { "entries", FLDT_ATTR_LEAF_ENTRY, OI(L3OFF(entries)), attr3_leaf_entries_count, FLD_ARRAY|FLD_COUNT, TYP_NONE }, { "btree", FLDT_ATTR_NODE_ENTRY, OI(N3OFF(__btree)), @@ -652,6 +829,9 @@ xfs_attr3_set_crc( xfs_buf_update_cksum(bp, XFS_ATTR3_RMT_CRC_OFF); return; default: + if (is_verity_file()) + return; + dbprintf(_("Unknown attribute buffer type!\n")); break; } @@ -687,6 +867,11 @@ xfs_attr3_db_read_verify( bp->b_ops = &xfs_attr3_rmt_buf_ops; break; default: + if (is_verity_file()) { + bp->b_ops = &xfs_attr3_rmtverity_buf_ops; + goto verify; + } + dbprintf(_("Unknown attribute buffer type!\n")); xfs_buf_ioerror(bp, -EFSCORRUPTED); return; diff --git a/db/attrshort.c b/db/attrshort.c index 7e5c94ca533d..1d26a358335f 100644 --- a/db/attrshort.c +++ b/db/attrshort.c @@ -20,6 +20,9 @@ static int attr_shortform_list_offset(void *obj, int startoff, int idx); static int attr_sf_entry_pptr_count(void *obj, int startoff); +static int attr_sf_entry_merkleoff_count(void *obj, int startoff); +static int attr_sf_entry_merkledata_count(void *obj, int startoff); + const field_t attr_shortform_flds[] = { { "hdr", FLDT_ATTR_SF_HDR, OI(0), C1, 0, TYP_NONE }, { "list", FLDT_ATTR_SF_ENTRY, attr_shortform_list_offset, @@ -35,6 +38,8 @@ const field_t attr_sf_hdr_flds[] = { }; #define EOFF(f) bitize(offsetof(struct xfs_attr_sf_entry, f)) +#define MKOFF(f) bitize(offsetof(struct xfs_attr_sf_entry, nameval) + \ + offsetof(struct xfs_merkle_key, f)) const field_t attr_sf_entry_flds[] = { { "namelen", FLDT_UINT8D, OI(EOFF(namelen)), C1, 0, TYP_NONE }, { "valuelen", FLDT_UINT8D, OI(EOFF(valuelen)), C1, 0, TYP_NONE }, @@ -48,10 +53,17 @@ const field_t attr_sf_entry_flds[] = { { "parent", FLDT_UINT1, OI(EOFF(flags) + bitsz(uint8_t) - XFS_ATTR_PARENT_BIT - 1), C1, 0, TYP_NONE }, + { "verity", FLDT_UINT1, + OI(EOFF(flags) + bitsz(uint8_t) - XFS_ATTR_VERITY_BIT - 1), C1, 0, + TYP_NONE }, { "name", FLDT_CHARNS, OI(EOFF(nameval)), attr_sf_entry_name_count, FLD_COUNT, TYP_NONE }, { "parent_dir", FLDT_PARENT_REC, attr_sf_entry_value_offset, attr_sf_entry_pptr_count, FLD_COUNT | FLD_OFFSET, TYP_NONE }, + { "merkle_pos", FLDT_UINT32X, OI(MKOFF(mk_pos)), + attr_sf_entry_merkleoff_count, FLD_COUNT, TYP_NONE }, + { "merkle_data", FLDT_HEXSTRING, attr_sf_entry_value_offset, + attr_sf_entry_merkledata_count, FLD_COUNT | FLD_OFFSET, TYP_NONE }, { "value", FLDT_CHARNS, attr_sf_entry_value_offset, attr_sf_entry_value_count, FLD_COUNT|FLD_OFFSET, TYP_NONE }, { NULL } @@ -100,6 +112,10 @@ attr_sf_entry_value_count( if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_PARENT) return 0; + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY && + e->namelen == sizeof(struct xfs_merkle_key)) + return 0; + return e->valuelen; } @@ -183,3 +199,37 @@ attr_sf_entry_pptr_count( return 1; } + +static int +attr_sf_entry_merkleoff_count( + void *obj, + int startoff) +{ + struct xfs_attr_sf_entry *e; + + ASSERT(bitoffs(startoff) == 0); + e = (struct xfs_attr_sf_entry *)((char *)obj + byteize(startoff)); + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) != XFS_ATTR_VERITY) + return 0; + + if (e->namelen != sizeof(struct xfs_merkle_key)) + return 0; + + return 1; +} + +static int +attr_sf_entry_merkledata_count( + void *obj, + int startoff) +{ + struct xfs_attr_sf_entry *e; + + ASSERT(bitoffs(startoff) == 0); + e = (struct xfs_attr_sf_entry *)((char *)obj + byteize(startoff)); + if ((e->flags & XFS_ATTR_NSP_ONDISK_MASK) == XFS_ATTR_VERITY && + e->namelen == sizeof(struct xfs_merkle_key)) + return e->valuelen; + + return 0; +}

[23/38] xfs_db: dump merkle tree data

Commit Message

Patch