[RFC,0/1] builtin/remote: quote remote name on error to display empty name

Message

Shulhan Sept. 12, 2018, 2:45 p.m. UTC

Rationale: consistent error format

When adding new remote name with empty string, git will print the
following error message,

  fatal: '' is not a valid remote name\n

But when removing remote name with empty string as input, git did not
print the empty string with quote,

  fatal: No such remote: \n

Follow up question: If this is ok, should the po files also updated?

This is my first patch, sorry if I did some mistakes.

Shulhan (1):
  builtin/remote: quote remote name on error to display empty name

 builtin/remote.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Junio C Hamano Sept. 12, 2018, 4:20 p.m. UTC | #1

Shulhan <[e-mail]> writes:

> Rationale: consistent error format
>
> When adding new remote name with empty string, git will print the
> following error message,
>
>   fatal: '' is not a valid remote name\n
>
> But when removing remote name with empty string as input, git did not
> print the empty string with quote,
>
>   fatal: No such remote: \n

Thanks for noticing.  I think the consistency given by the patch 1/1
is good.

> Follow up question: If this is ok, should the po files also updated?

They should be updated, but not by you and not as part of this
change.  The po files will be updated by our l10n coordinator,
typically when it gets close to the release time, for all the
message changes done during the release cycle.

Thanks.