| Message ID | 20181216215759.24011-1-nbelakovski@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | [v3,1/3] ref-filter: add worktreepath atom | expand |
On Sun, Dec 16, 2018 at 01:57:56PM -0800, nbelakovski@gmail.com wrote: > Finally got around to submitting latest changes. > > I think this addresses all the feedback > > The atom now returns the worktree path instead of '+' Thanks, I think patch 1 is definitely going in the right direction. There are a few issues I found in its implementation, but they should be easy to fix (and won't affect the other patches). I don't really have a strong opinion on the behavior of the other patches. -Peff
From: Nickolai Belakovski <nbelakovski@gmail.com> Finally got around to submitting latest changes. I think this addresses all the feedback The atom now returns the worktree path instead of '+' I stuck to cyan for the coloring, since it seemed most popular I added one more change to display the worktree path in cyan for git branch -vvv Not sure if it's in the best place, but it seemed like it would be nice to add the path in the same color so that there's some visibility as to why a particular branch is colored in cyan. If it proves to be controversial, I wouldn't want it to hold up this series, we can skip it and I can move discussion to a separate thread (or just forget it, as the case may be) Travis CI results: https://travis-ci.org/nbelakovski/git/builds/468569102 Nickolai Belakovski (3): ref-filter: add worktreepath atom branch: Mark and color a branch differently if it is checked out in a linked worktree branch: Add an extra verbose output displaying worktree path for refs checked out in a linked worktree Documentation/git-for-each-ref.txt | 4 +++ builtin/branch.c | 16 ++++++--- ref-filter.c | 70 ++++++++++++++++++++++++++++++++++++++ t/t3200-branch.sh | 8 ++--- t/t3203-branch-output.sh | 21 ++++++++++++ t/t6302-for-each-ref-filter.sh | 15 ++++++++ 6 files changed, 126 insertions(+), 8 deletions(-)