[v2,0/3] blame: add the ability to ignore commits

Message

Barret Rhoden Jan. 17, 2019, 8:29 p.m. UTC

Adds the ability to ignore a set of commits and their changes when
blaming.  This can be used to ignore a commit deemed 'not interesting,'
such as reformatting.

v1: https://public-inbox.org/git/[e-mail]/
v1 -> v2
- extracted the skiplist from fsck to avoid duplicating code
- overhauled the interface and options
- split out markIgnoredFiles
- handled merges

Barret Rhoden (3):
  Move init_skiplist() outside of fsck
  blame: add the ability to ignore commits and their changes
  blame: add a config option to mark ignored lines

 Documentation/blame-options.txt | 15 +++++++++
 Documentation/git-blame.txt     |  1 +
 blame.c                         | 56 +++++++++++++++++++++++++++------
 blame.h                         |  3 ++
 builtin/blame.c                 | 33 +++++++++++++++++++
 fsck.c                          | 37 +---------------------
 oidset.c                        | 35 +++++++++++++++++++++
 oidset.h                        |  7 +++++
 8 files changed, 142 insertions(+), 45 deletions(-)

Comments

Ævar Arnfjörð Bjarmason Jan. 18, 2019, 9:52 a.m. UTC | #1

On Thu, Jan 17 2019, Barret Rhoden wrote:

> Adds the ability to ignore a set of commits and their changes when
> blaming.  This can be used to ignore a commit deemed 'not interesting,'
> such as reformatting.
>
> v1: https://public-inbox.org/git/[e-mail]/
> v1 -> v2
> - extracted the skiplist from fsck to avoid duplicating code
> - overhauled the interface and options
> - split out markIgnoredFiles
> - handled merges
>
> Barret Rhoden (3):
>   Move init_skiplist() outside of fsck
>   blame: add the ability to ignore commits and their changes
>   blame: add a config option to mark ignored lines

Looks much better this time around, I skimmed it, but quickly discovered
that there's no tests for any of it, which is a prerequisite for getting
something like this in.