[v7,0/6] Finish converting git bisect to C part 4

Message

Miriam R. Sept. 13, 2021, 5:38 p.m. UTC

These patches correspond to a fourth part of patch series 
of Outreachy project "Finish converting `git bisect` from shell to C" 
started by Pranit Bauva and Tanushree Tumane
(https://public-inbox.org/git/[e-mail]) and
continued by me.

This fourth part is formed by reimplementations of some `git bisect` 
subcommands, addition of tests and removal of some temporary subcommands.

These patch series emails were generated from:
https://gitlab.com/mirucam/git/commits/git-bisect-work-part4-v7.

I would like to thank Junio Hamano and Johannes Schindelin for reviewing
this patch series.

Specific changes
----------------

[1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases
* Remove unnecessary redirections to /dev/null and my_bisect_log.txt
---

[2/6]t6030-bisect-porcelain: add test for bisect visualize
* Remove redirection and add double quotes to test's filename

---

[3/6]run-command: make `exists_in_PATH()` non-static
* Amend commit message.
* Change parameter name.
---

[4/6]bisect--helper: reimplement `bisect_visualize()` shell function in C
* Add brackets to an if expression.
---

[5/6] bisect--helper: reimplement `bisect_run` shell function in C
* Add two fflush(stdout) in dup2 dance.
* Rewrite if-else condition.


---


Miriam Rubio (3):
  t6030-bisect-porcelain: add tests to control bisect run exit cases
  t6030-bisect-porcelain: add test for bisect visualize
  bisect--helper: retire `--bisect-next-check` subcommand

Pranit Bauva (2):
  run-command: make `exists_in_PATH()` non-static
  bisect--helper: reimplement `bisect_visualize()` shell function in C

Tanushree Tumane (1):
  bisect--helper: reimplement `bisect_run` shell function in C

 builtin/bisect--helper.c    | 158 ++++++++++++++++++++++++++++++++++--
 git-bisect.sh               |  87 +-------------------
 run-command.c               |   4 +-
 run-command.h               |  12 +++
 t/t6030-bisect-porcelain.sh |  18 ++++
 5 files changed, 184 insertions(+), 95 deletions(-)