mbox series

[RFC,0/1] protocol-v2.txt: align delim-pkt spec with usage

Message ID 20211027193501.556540-1-calvinwan@google.com (mailing list archive)
Headers show
Series protocol-v2.txt: align delim-pkt spec with usage | expand

Message

Calvin Wan Oct. 27, 2021, 7:35 p.m. UTC
In the grammar for a command the "delim-pkt" is optional, and a command could be followed by a "flush-pkt". On the other hand, JGit code is assuming that there is ALWAYS a DELIM package after command. I.e. messages valid following the grammar would fail in JGit. This is not causing troubles because all commands (ls-refs and fetch) have command-args. This problem arose when adding parsing for the "capability-list" So, bug here is align protocol grammar and code expectations. Given that a. most commands have args, and b. having delim-pkt between sections simplifies parsing, delim-pkt should be mandatory.

Calvin Wan (1):

 Documentation/technical/protocol-v2.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 0785eb769886ae81e346df10e88bc49ffc0ac64e