mbox series

[0/2] dirstat: leakfix

Message ID 20230505211917.2746751-1-gitster@pobox.com (mailing list archive)
Headers show
Series dirstat: leakfix | expand

Message

Junio C Hamano May 5, 2023, 9:19 p.m. UTC 
Junio C Hamano <gitster@pobox.com> writes:

>  t/t4000-diff-format.sh         | 34 +++++++++++++++++++++++++++++++++-
> ...
> +for format in stat raw numstat shortstat summary \
> +	dirstat cumulative dirstat-by-file \
> +	patch-with-raw patch-with-stat compact-summary

Unfortunately, because t4000 is marked as passing with leak
sanitizer on, even though this series does not introduce any new
leaks (in fact, there is nothing in the series that allocates pieces
of memory at all), the CI will fail with the sanitizer job.

Needless to say, I hate the current arrangement of these tests.
Those who happen to use tools or features that have nothing to do
with the topic being developed that introduces no new leaks are
punished by a test failure.

Here are a pair of patches that plug leaks in dirstat code.  This
allows the "fix interaction between -s and others" patch that adds
a test that exercises --dirstat in t4000 to be queued without
breaking the leak sanitizer.

Also t4047 that is about dirstat can now be marked as leak free.

Junio C Hamano (2):
  diff: refactor common tail part of dirstat computation
  diff: plug leaks in dirstat

 diff.c                  | 34 ++++++++++++++++++++--------------
 t/t4047-diff-dirstat.sh |  2 ++
 2 files changed, 22 insertions(+), 14 deletions(-)