mbox series

[v3,0/3] rebase refactoring

Message ID 20231020093654.922890-1-oswald.buddenhagen@gmx.de (mailing list archive)
Headers show
Series rebase refactoring | expand

Message

Oswald Buddenhagen Oct. 20, 2023, 9:36 a.m. UTC
broken out of the bigger series, as the aggregation just unnecessarily holds it
up.

v3: removed "stray" footer. so more of a RESEND than an actual new version.

Oswald Buddenhagen (3):
  rebase: simplify code related to imply_merge()
  rebase: handle --strategy via imply_merge() as well
  rebase: move parse_opt_keep_empty() down

 builtin/rebase.c | 44 ++++++++++++++------------------------------
 1 file changed, 14 insertions(+), 30 deletions(-)

Comments

Junio C Hamano Oct. 20, 2023, 10:07 p.m. UTC | #1
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:

> broken out of the bigger series, as the aggregation just unnecessarily holds it
> up.
>
> v3: removed "stray" footer. so more of a RESEND than an actual new version.
>
> Oswald Buddenhagen (3):
>   rebase: simplify code related to imply_merge()
>   rebase: handle --strategy via imply_merge() as well
>   rebase: move parse_opt_keep_empty() down
>
>  builtin/rebase.c | 44 ++++++++++++++------------------------------
>  1 file changed, 14 insertions(+), 30 deletions(-)

Looking quite straight-forward and I didn't see anythihng
potentially controversial.

Will queue.  Thanks.
Phillip Wood Oct. 23, 2023, 3:43 p.m. UTC | #2
On 20/10/2023 23:07, Junio C Hamano wrote:
> Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> 
>> broken out of the bigger series, as the aggregation just unnecessarily holds it
>> up.
>>
>> v3: removed "stray" footer. so more of a RESEND than an actual new version.
>>
>> Oswald Buddenhagen (3):
>>    rebase: simplify code related to imply_merge()
>>    rebase: handle --strategy via imply_merge() as well
>>    rebase: move parse_opt_keep_empty() down
>>
>>   builtin/rebase.c | 44 ++++++++++++++------------------------------
>>   1 file changed, 14 insertions(+), 30 deletions(-)
> 
> Looking quite straight-forward and I didn't see anythihng
> potentially controversial.

Yes they look good, thanks Oswald

Best Wishes

Phillip
Junio C Hamano Oct. 23, 2023, 7:02 p.m. UTC | #3
Phillip Wood <phillip.wood123@gmail.com> writes:

> On 20/10/2023 23:07, Junio C Hamano wrote:
>> Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
>> 
>>> broken out of the bigger series, as the aggregation just unnecessarily holds it
>>> up.
>>>
>>> v3: removed "stray" footer. so more of a RESEND than an actual new version.
>>>
>>> Oswald Buddenhagen (3):
>>>    rebase: simplify code related to imply_merge()
>>>    rebase: handle --strategy via imply_merge() as well
>>>    rebase: move parse_opt_keep_empty() down
>>>
>>>   builtin/rebase.c | 44 ++++++++++++++------------------------------
>>>   1 file changed, 14 insertions(+), 30 deletions(-)
>> Looking quite straight-forward and I didn't see anythihng
>> potentially controversial.
>
> Yes they look good, thanks Oswald

Thanks, both.  The topic has already been merged to 'next'.