[0/6] fast-import: tighten parsing of paths

Message ID	20240322000304.76810-1-thalia@archibald.dev (mailing list archive)
Headers	show Received: from mail-4321.protonmail.ch (mail-4321.protonmail.ch [185.70.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775F9376 for <git@vger.kernel.org>; Fri, 22 Mar 2024 00:21:50 +0000 (UTC) Date: Fri, 22 Mar 2024 00:03:10 +0000 To: git@vger.kernel.org From: Thalia Archibald <thalia@archibald.dev> Cc: Elijah Newren <newren@gmail.com> Subject: [PATCH 0/6] fast-import: tighten parsing of paths Message-ID: <20240322000304.76810-1-thalia@archibald.dev> Feedback-ID: 63908566:user:proton Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Series	fast-import: tighten parsing of paths \| expand [0/6] fast-import: tighten parsing of paths [1/6] fast-import: tighten parsing of paths [2/6] fast-import: directly use strbufs for paths [3/6] fast-import: release unfreed strbufs [4/6] fast-import: remove dead strbuf [5/6] fast-import: document C-style escapes for paths [6/6] fast-import: forbid escaped NUL in paths

Message ID

20240322000304.76810-1-thalia@archibald.dev (mailing list archive)

Headers

Date: Fri, 22 Mar 2024 00:03:10 +0000
To: git@vger.kernel.org
From: Thalia Archibald <thalia@archibald.dev>
Cc: Elijah Newren <newren@gmail.com>
Subject: [PATCH 0/6] fast-import: tighten parsing of paths
Message-ID: <20240322000304.76810-1-thalia@archibald.dev>
Feedback-ID: 63908566:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Series

fast-import: tighten parsing of paths | expand

Message

Thalia Archibald March 22, 2024, 12:03 a.m. UTC

fast-import has subtle differences in how it parses file paths between each
occurrence of <path> in the grammar. Many errors are suppressed or not checked,
which could lead to silent data corruption. A particularly bad case is when a
front-end sent escapes that Git doesn't recognize (e.g., hex escapes are not
supported), it would be treated as literal bytes instead of a quoted string.

Bring path parsing into line with the documented behavior and improve
documentation to fill in missing details.

This patch series is patterned after 06454cb9a3 (fast-import: tighten parsing of
datarefs, 2012-04-07), which did similar fixes across the grammar, but for
marks.

This is my first contribution to Git, so please let me know if there's something
I've missed. I'm working on a tool for advanced repo transformations (like a
union of filter-repo and Reposurgeon workflows), so I've been living in
fast-import code and I have more parsing fixes planned.

Thalia