[0/5] add-ons for ps/leakfixes

Message

Jeff King May 30, 2024, 6:38 a.m. UTC

Here are a few patches to go on top of ps/leakfixes. Patches 1 and 3 fix
functional problems noticed by Coverity, and then the others are just
cleanups I noticed while there.

  [1/5]: t-strvec: use va_end() to match va_start()
  [2/5]: t-strvec: mark variable-arg helper with LAST_ARG_MUST_BE_NULL
  [3/5]: mv: move src_dir cleanup to end of cmd_mv()
  [4/5]: mv: factor out empty src_dir removal
  [5/5]: mv: replace src_dir with a strvec

 builtin/mv.c            | 50 +++++++++++++++++++++--------------------
 t/unit-tests/t-strvec.c |  3 +++
 2 files changed, 29 insertions(+), 24 deletions(-)

-Peff

Comments

Patrick Steinhardt May 30, 2024, 7:05 a.m. UTC | #1

On Thu, May 30, 2024 at 02:38:57AM -0400, Jeff King wrote:
> Here are a few patches to go on top of ps/leakfixes. Patches 1 and 3 fix
> functional problems noticed by Coverity, and then the others are just
> cleanups I noticed while there.
> 
>   [1/5]: t-strvec: use va_end() to match va_start()
>   [2/5]: t-strvec: mark variable-arg helper with LAST_ARG_MUST_BE_NULL
>   [3/5]: mv: move src_dir cleanup to end of cmd_mv()
>   [4/5]: mv: factor out empty src_dir removal
>   [5/5]: mv: replace src_dir with a strvec

Thanks for the follow up, and thank especially for improving
builtin/mv.c a bit further. The patches all look good to me.

Patrick