mbox series

[0/2] Re: [BUG REPORT] git-gui invokes prepare-commit-msg hook incorrectly

Message ID 20240813090631.1133049-1-oswald.buddenhagen@gmx.de (mailing list archive)
Headers show
Series Re: [BUG REPORT] git-gui invokes prepare-commit-msg hook incorrectly | expand

Message

Oswald Buddenhagen Aug. 13, 2024, 9:06 a.m. UTC 
> >> So it still seems like we have two real options:
> >>
> >> - Start washing the message, allowing the prepare-commit-msg hook to
> >>   provide template-like guidance to the user regardless of if they are
> >>   using git-gui or some other editor, or
> >> - Pass the "message" argument along to the prepare-commit-msg hook so
> >>   that it can at least avoid adding template-like content (but of course
> >>   then lose the value added by that template).
> >
> i'm strongly in favor of the first option.
> it also seems to be the much easier one to implement.
>
so i thought i'd just give it a shot ...

fwiw, it's debatable whether it (stil) makes sense that git-gui reimplements
git-commit - maybe it should just call it. then the patch would boil down to
adding --cleanup=strip to the command line.

---

Cc: Johannes Sixt <j6t@kdbg.org>
Cc: Brian Lyles <brianmlyles@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>
Cc: Sean Allred <allred.sean@gmail.com>

Oswald Buddenhagen (2):
  git-gui: strip comments and consecutive empty lines from commit
    messages
  git-gui: strip commit messages less aggressively

 git-gui/lib/commit.tcl | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)