[v8,0/6] add remote-object-info to batch-command

Message

Eric Ju Dec. 23, 2024, 11:25 p.m. UTC

This patch series is a continuation of Calvin Wan’s ([e-mail])
patch series [PATCH v5 0/6] cat-file: add --batch-command remote-object-info
command at [1].

Sometimes it is beneficial to retrieve information about an object without
having to download it completely. The server logic for retrieving size has
already been implemented and merged in "a2ba162cda (object-info: support for
retrieving object info, 2021-04-20)"[2]. This patch series implement the client
option for it.

This patch series add the `remote-object-info` command to
`cat-file --batch-command`. This command allows the client to make an
object-info command request to a server that supports protocol v2.

If the server uses protocol v2 but does not support the object-info capability,
`cat-file --batch-command` will die.

If a user attempts to use `remote-object-info` with protocol v1,,
`cat-file --batch-command` will die.

Currently, only the size (%(objectsize)) is supported in this implementation.
The type (%(objecttype)) is not included in this patch series, as it is not yet
supported on the server side either. The plan is to implement the necessary
logic for both the server and client in a subsequent series.

The default format for remote-object-info is set to %(objectname) %(objectsize).
Once %(objecttype) is supported, the default format will be unified accordingly.

If the batch command format includes unsupported fields such as %(objecttype),
%(objectsize:disk), or %(deltabase), the command will terminate with an error.

Changes since V7
================
- Introduced strtoul_ul() in git-compat-util.h to ensure proper error handling
  using strtoul from the standard library.
- Separated the test library into its own commit for better clarity
  and organization.
- Use string_list_has_string() instead of unsorted_string_list_has_string() to
  avoid quadratic runtime behaviour
- Added a documentation link to the wire format in the commit message to
  provide additional context.
- New test case "remote-object-info fails on not providing OID"
- Fixed typos and formatting issues for improved readability.

Calvin Wan (4):
  fetch-pack: refactor packet writing
  fetch-pack: move fetch initialization
  serve: advertise object-info feature
  transport: add client support for object-info

Eric Ju (2):
  cat-file: add declaration of variable i inside its for loop
  cat-file: add remote-object-info to batch-command

 Documentation/git-cat-file.txt         |  24 +-
 Makefile                               |   1 +
 builtin/cat-file.c                     | 110 ++++-
 connect.c                              |  34 ++
 connect.h                              |   8 +
 fetch-object-info.c                    |  92 ++++
 fetch-object-info.h                    |  18 +
 fetch-pack.c                           |  51 +-
 fetch-pack.h                           |   2 +
 object-file.c                          |  11 +
 object-store-ll.h                      |   3 +
 serve.c                                |   4 +-
 t/lib-cat-file.sh                      |  16 +
 t/t1006-cat-file.sh                    |  13 +-
 t/t1017-cat-file-remote-object-info.sh | 652 +++++++++++++++++++++++++
 transport-helper.c                     |  11 +-
 transport.c                            |  28 +-
 transport.h                            |  11 +
 18 files changed, 1021 insertions(+), 68 deletions(-)
 create mode 100644 fetch-object-info.c
 create mode 100644 fetch-object-info.h
 create mode 100644 t/lib-cat-file.sh
 create mode 100755 t/t1017-cat-file-remote-object-info.sh

Range-diff against v7:
-:  ---------- > 1:  c09e21a9d6 cat-file: add declaration of variable i inside its for loop
-:  ---------- > 2:  ed04a4a7c4 fetch-pack: refactor packet writing
-:  ---------- > 3:  bc52c4f80c fetch-pack: move fetch initialization
-:  ---------- > 4:  4c1b989c41 serve: advertise object-info feature
-:  ---------- > 5:  dbc95a9ae5 transport: add client support for object-info
-:  ---------- > 6:  f244ec8a2f cat-file: add remote-object-info to batch-command

Comments

Junio C Hamano Dec. 26, 2024, 9:56 p.m. UTC | #1

Eric Ju <[e-mail]> writes:

> Range-diff against v7:
> -:  ---------- > 1:  c09e21a9d6 cat-file: add declaration of variable i inside its for loop
> -:  ---------- > 2:  ed04a4a7c4 fetch-pack: refactor packet writing
> -:  ---------- > 3:  bc52c4f80c fetch-pack: move fetch initialization
> -:  ---------- > 4:  4c1b989c41 serve: advertise object-info feature
> -:  ---------- > 5:  dbc95a9ae5 transport: add client support for object-info
> -:  ---------- > 6:  f244ec8a2f cat-file: add remote-object-info to batch-command

This is curious.  Did you compare the right things?

    -- 
    2.47.0

    Information Footer:
    base-commit: 8f8d6eee531b3fa1a8ef14f169b0cb5035f7a772
    Merge Request: https://gitlab.com/gitlab-org/git/-/merge_requests/168

If the base-commit information is relevant, please do not write it
below the "signature" like (i.e. a line that consists only of
dash-dash-space near the end of the message), as some e-mail programs
consider them irrelevant and omit from quoting.

I tried to apply them on top of 8f8d6eee (The seventh batch,
2024-11-01) but the last step [6/6] fails to apply (the first five
applied cleanly, and matched what I already had).

Could you help to figure out what is going wrong on your end?

Thanks.

Eric Ju Dec. 30, 2024, 11:25 p.m. UTC | #2

Sorry for the noise. I forgot to CC others, so I am resending it.

On Thu, Dec 26, 2024 at 5:56 PM Junio C Hamano <[e-mail]> wrote:
>
> Eric Ju <[e-mail]> writes:
>
> > Range-diff against v7:
> > -:  ---------- > 1:  c09e21a9d6 cat-file: add declaration of variable i inside its for loop
> > -:  ---------- > 2:  ed04a4a7c4 fetch-pack: refactor packet writing
> > -:  ---------- > 3:  bc52c4f80c fetch-pack: move fetch initialization
> > -:  ---------- > 4:  4c1b989c41 serve: advertise object-info feature
> > -:  ---------- > 5:  dbc95a9ae5 transport: add client support for object-info
> > -:  ---------- > 6:  f244ec8a2f cat-file: add remote-object-info to batch-command
>
> This is curious.  Did you compare the right things?
>


Thank you.

I think I may compare it wrong.

>     --
>     2.47.0
>
>     Information Footer:
>     base-commit: 8f8d6eee531b3fa1a8ef14f169b0cb5035f7a772
>     Merge Request: https://gitlab.com/gitlab-org/git/-/merge_requests/168
>
> If the base-commit information is relevant, please do not write it
> below the "signature" like (i.e. a line that consists only of
> dash-dash-space near the end of the message), as some e-mail programs
> consider them irrelevant and omit from quoting.
>

Roger that.

> I tried to apply them on top of 8f8d6eee (The seventh batch,
> 2024-11-01) but the last step [6/6] fails to apply (the first five
> applied cleanly, and matched what I already had).
>
> Could you help to figure out what is going wrong on your end?
>

Should I resend v8 or send a v9 instead?

> Thanks.