mbox series

[v3,0/1] Long names for `git log -S` and `git log -G`

Message ID 20250206014324.1839232-1-illia.bobyr@gmail.com (mailing list archive)
Headers show
Series Long names for `git log -S` and `git log -G` | expand

Message

Illia Bobyr Feb. 6, 2025, 1:43 a.m. UTC 
Same as PATCH v2[1], but removed gitk changes, as suggested by Johannes Sixt.

I'll send a separate patch for gitk, should this patch be accepted.
Or, I could include gitk changes into this chain, but just as a separate patch?

[1]: https://lore.kernel.org/git/20250205022422.2019929-1-illia.bobyr@gmail.com/

Illia Bobyr (1):
  diff: --patch-{modifies,grep} arg names for -S and -G

 Documentation/diff-options.txt |  36 +++++------
 Documentation/git-blame.txt    |   2 +-
 Documentation/gitdiffcore.txt  |  48 ++++++++-------
 diff.c                         |  18 +++---
 diff.h                         |  11 +++-
 t/t4062-diff-pickaxe.sh        |   8 +--
 t/t4209-log-pickaxe.sh         | 106 +++++++++++++++++++++++----------
 7 files changed, 142 insertions(+), 87 deletions(-)

Comments

Junio C Hamano Feb. 6, 2025, 1:04 p.m. UTC | #1 
Illia Bobyr <illia.bobyr@gmail.com> writes:

> Same as PATCH v2[1], but removed gitk changes, as suggested by Johannes Sixt.
>
> I'll send a separate patch for gitk, should this patch be accepted.
> Or, I could include gitk changes into this chain, but just as a separate patch?

They are technically separate codebases so the changes to the core
would become prerequisite for the same changes to gitk, so from that
point of view the former may be more kosher, but I would expect that
the latter is fine in practice.