| Message ID | 20250319020221.2160371-1-05ZYT30@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | sendemail: improve error capture and status code handling | expand |
On Wed, 19 Mar 2025 at 07:32, Zheng Yuting <05zyt30@gmail.com> wrote: > > This patch series improves SMTP authentication error handling. > > Auth relied solely on return values without capturing exceptions, > misjudging non-credential errors as authentication failures. > > Patch v5 1/2 wraps the auth process in an eval {} block to catch all > exceptions, adds var error for future handling, and var result to return > auth state. > > Patch v5 2/2 introduces finer-grained SMTP error handling, extracting > status codes per RFC 5321 to differentiate between temporary (4yz) and > permanent (5yz) errors. Unrecognized codes are treated as permanent > failures. Otherwise return the authentication result. > > > Zheng Yuting (2): > sendemail: capture errors in an eval {} block > sendemail: finer-grained SMTP error handling > I'm not sure if this is worth a re-roll but, `sendemail` should be `send-email`. > git-send-email.perl | 62 ++++++++++++++++++++++++++++++++------------- > 1 file changed, 45 insertions(+), 17 deletions(-) > > -- > 2.48.1 > Thanks
This patch series improves SMTP authentication error handling. Auth relied solely on return values without capturing exceptions, misjudging non-credential errors as authentication failures. Patch v5 1/2 wraps the auth process in an eval {} block to catch all exceptions, adds var error for future handling, and var result to return auth state. Patch v5 2/2 introduces finer-grained SMTP error handling, extracting status codes per RFC 5321 to differentiate between temporary (4yz) and permanent (5yz) errors. Unrecognized codes are treated as permanent failures. Otherwise return the authentication result. Zheng Yuting (2): sendemail: capture errors in an eval {} block sendemail: finer-grained SMTP error handling git-send-email.perl | 62 ++++++++++++++++++++++++++++++++------------- 1 file changed, 45 insertions(+), 17 deletions(-) -- 2.48.1