[0/12] more unused-parameter fixes / annotations

Message

Jeff King Oct. 18, 2022, 1 a.m. UTC

Here's another batch of UNUSED markings. I've floated the less-obvious
ones to the top. Patches 4-12 are trivially correct in the sense that
the compiler would tell us if we were wrong about it being unused. But I
tried where appropriate to reason out why ignoring a parameter wasn't an
unintentional bug.

  [01/12]: diffstat_consume(): assert non-zero length
  [02/12]: submodule--helper: drop unused argc from module_list_compute()
  [03/12]: update-index: drop unused argc from do_reupdate()
  [04/12]: mark unused parameters in trivial compat functions
  [05/12]: object-file: mark unused parameters in hash_unknown functions
  [06/12]: string-list: mark unused callback parameters
  [07/12]: date: mark unused parameters in handler functions
  [08/12]: apply: mark unused parameters in handlers
  [09/12]: apply: mark unused parameters in noop error/warning routine
  [10/12]: convert: mark unused parameter in null stream filter
  [11/12]: diffcore-pickaxe: mark unused parameters in pickaxe functions
  [12/12]: ll-merge: mark unused parameters in callbacks

 apply.c                     | 18 +++++++++---------
 archive.c                   |  2 +-
 builtin/gc.c                |  2 +-
 builtin/remote.c            |  2 +-
 builtin/submodule--helper.c | 18 +++++++++---------
 builtin/update-index.c      |  6 +++---
 compat/nonblock.c           |  2 +-
 convert.c                   |  4 ++--
 date.c                      |  6 +++---
 diff.c                      |  3 +++
 diffcore-pickaxe.c          |  4 ++--
 exec-cmd.c                  |  2 +-
 git-compat-util.h           | 16 ++++++++++------
 ll-merge.c                  | 18 +++++++++---------
 merge-ort.c                 |  2 +-
 object-file.c               | 15 ++++++++++-----
 reflog-walk.c               |  2 +-
 string-list.c               |  2 +-
 t/helper/test-path-utils.c  |  3 ++-
 19 files changed, 70 insertions(+), 57 deletions(-)

-Peff