| Message ID | cover.1551123979.git.martin.agren@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | asciidoctor-extensions: fix spurious space after linkgit | expand |
On Mon, Feb 25, 2019 at 09:02:37PM +0100, Martin Ågren wrote: > Patch 3/3 gets rid of a spurious space which shows up immediately after > Asciidoctor has expanded linkgit:foo[bar] if the macro is followed by > punctuation such as a comma, period or closing parenthesis. > > Patch 2/3 adds a missing dependency to the makefile, so that the docs > will actually be rebuilt with that final patch. Patch 1/3 isn't needed > for this series, but could help someone in the future, similar to how > already having patch 2/3 would have helped me... > > Martin Ågren (3): > Documentation/Makefile: add missing xsl dependencies for manpages > Documentation/Makefile: add missing dependency on > asciidoctor-extensions > asciidoctor-extensions: fix spurious space after linkgit > > Documentation/Makefile | 4 ++-- > Documentation/asciidoctor-extensions.rb | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Thanks for putting this series together. I would suggest an update to the commit message in 1/3 explaining the edge case that Eric Sunshine mentioned, but otherwise, I think this looks good.
On Tue, 26 Feb 2019 at 04:22, brian m. carlson <sandals@crustytoothpaste.net> wrote: > > Thanks for putting this series together. I would suggest an update to > the commit message in 1/3 explaining the edge case that Eric Sunshine > mentioned, but otherwise, I think this looks good. Thank you. I'll do that, after waiting for a while for any other comments, and to see what conclusion I and Eric can reach on the `make distclean` tangent. Martin
Patch 3/3 gets rid of a spurious space which shows up immediately after Asciidoctor has expanded linkgit:foo[bar] if the macro is followed by punctuation such as a comma, period or closing parenthesis. Patch 2/3 adds a missing dependency to the makefile, so that the docs will actually be rebuilt with that final patch. Patch 1/3 isn't needed for this series, but could help someone in the future, similar to how already having patch 2/3 would have helped me... Martin Ågren (3): Documentation/Makefile: add missing xsl dependencies for manpages Documentation/Makefile: add missing dependency on asciidoctor-extensions asciidoctor-extensions: fix spurious space after linkgit Documentation/Makefile | 4 ++-- Documentation/asciidoctor-extensions.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)