mbox series

[v2,0/7] Better threaded delta resolution in index-pack (another try)

Message ID cover.1599594441.git.jonathantanmy@google.com (mailing list archive)
Headers show
Series Better threaded delta resolution in index-pack (another try) | expand

Message

Jonathan Tan Sept. 8, 2020, 7:48 p.m. UTC 
From What's Cooking [1]:

> * jt/threaded-index-pack (2020-08-27) 9 commits
>  - builtin/index-pack.c: fix some sparse warnings
>  - fixup! index-pack: make quantum of work smaller
>  - index-pack: make quantum of work smaller
>  - index-pack: make resolve_delta() assume base data
>  - index-pack: calculate {ref,ofs}_{first,last} early
>  - index-pack: remove redundant child field
>  - index-pack: unify threaded and unthreaded code
>  - index-pack: remove redundant parameter
>  - Documentation: deltaBaseCacheLimit is per-thread
> 
>  "git index-pack" learned to resolve deltified objects with greater
>  parallelism.
> 
>  Expecting the final reroll.
>  cf. https://colabti.org/irclogger/irclogger_log/git-devel?date=2020-08-31#l82

Here's the reroll.

[1] https://lore.kernel.org/git/xmqqk0xa8rvn.fsf@gitster.c.googlers.com/

Jonathan Tan (7):
  Documentation: deltaBaseCacheLimit is per-thread
  index-pack: remove redundant parameter
  index-pack: unify threaded and unthreaded code
  index-pack: remove redundant child field
  index-pack: calculate {ref,ofs}_{first,last} early
  index-pack: make resolve_delta() assume base data
  index-pack: make quantum of work smaller

 Documentation/config/core.txt |   2 +-
 builtin/index-pack.c          | 456 +++++++++++++++++++---------------
 2 files changed, 251 insertions(+), 207 deletions(-)

Comments

Junio C Hamano Sept. 8, 2020, 10:53 p.m. UTC | #1 
Jonathan Tan <jonathantanmy@google.com> writes:

> Here's the reroll.
>
> [1] https://lore.kernel.org/git/xmqqk0xa8rvn.fsf@gitster.c.googlers.com/

It seems that the only changes (as expected) are squashing in the
follow-up "oops" fixes into the right place in the series?

Will replace; thanks.


>
> Jonathan Tan (7):
>   Documentation: deltaBaseCacheLimit is per-thread
>   index-pack: remove redundant parameter
>   index-pack: unify threaded and unthreaded code
>   index-pack: remove redundant child field
>   index-pack: calculate {ref,ofs}_{first,last} early
>   index-pack: make resolve_delta() assume base data
>   index-pack: make quantum of work smaller
>
>  Documentation/config/core.txt |   2 +-
>  builtin/index-pack.c          | 456 +++++++++++++++++++---------------
>  2 files changed, 251 insertions(+), 207 deletions(-)