mbox series

[0/2] pack-format.txt: document lengths at start of delta data

Message ID cover.1608537234.git.martin.agren@gmail.com (mailing list archive)
Headers show
Series pack-format.txt: document lengths at start of delta data | expand

Message

Martin Ågren Dec. 21, 2020, 7:54 a.m. UTC 
Hi Ross,

Welcome to the list and thanks for reporting your findings. I haven't
looked at all at the first issue you brought up, about the protocol-v2
doc.

On Sat, 19 Dec 2020 at 18:10, Ross Light <ross@zombiezen.com> wrote:
> 2. In the pack-format doc, the Deltified representation section [2]
> describes the instruction sequence well, but neglects to mention the
> two size varints [3] at the beginning of such an object.

Would something like this be what you have in mind?

Martin Ågren (2):
  pack-format.txt: define "varint" format
  pack-format.txt: document lengths at start of delta data

 Documentation/technical/pack-format.txt | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

Comments

Ross Light Dec. 23, 2020, 4:40 a.m. UTC | #1 
Looks good to me, FWIW. Thank you! :)

-Ross

On Sun, Dec 20, 2020 at 11:55 PM Martin Ågren <martin.agren@gmail.com> wrote:
>
> Hi Ross,
>
> Welcome to the list and thanks for reporting your findings. I haven't
> looked at all at the first issue you brought up, about the protocol-v2
> doc.
>
> On Sat, 19 Dec 2020 at 18:10, Ross Light <ross@zombiezen.com> wrote:
> > 2. In the pack-format doc, the Deltified representation section [2]
> > describes the instruction sequence well, but neglects to mention the
> > two size varints [3] at the beginning of such an object.
>
> Would something like this be what you have in mind?
>
> Martin Ågren (2):
>   pack-format.txt: define "varint" format
>   pack-format.txt: document lengths at start of delta data
>
>  Documentation/technical/pack-format.txt | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
>
> --
> 2.30.0.rc1
>