[0/4] sequencer: clarify translations

Message

Michael J Gruber Aug. 18, 2022, 1:13 p.m. UTC

Hi there,

thanks for all your input to my RFC patch. I tried to summarize and pack
everything up into this little series.

A follow-up could (but does not have to) turn translated action names
into untranslated git command names in some places.

Cheers
Michael

Michael J Gruber (4):
  sequencer: do not translate reflog messages
  sequencer: do not translate parameters to error_resolve_conflict()
  sequencer: do not translate command names
  po: adjust README to code

 po/README.md |  2 +-
 sequencer.c  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Johannes Schindelin Aug. 19, 2022, 9:32 a.m. UTC | #1

Hi Michael,

On Thu, 18 Aug 2022, Michael J Gruber wrote:

> thanks for all your input to my RFC patch. I tried to summarize and pack
> everything up into this little series.
>
> A follow-up could (but does not have to) turn translated action names
> into untranslated git command names in some places.

Thank you for persisting on this, and on behalf of the core Git reviewers
I would like to apologize for the hornets' nest.

I offer my ACK to this iteration of the patch series, with or without the
v2 of patch 4/4.

Ciao,
Dscho

Michael J Gruber Aug. 19, 2022, 10:19 a.m. UTC | #2

Am Fr., 19. Aug. 2022 um 11:32 Uhr schrieb Johannes Schindelin
<[e-mail]>:
>
> Hi Michael,
>
> On Thu, 18 Aug 2022, Michael J Gruber wrote:
>
> > thanks for all your input to my RFC patch. I tried to summarize and pack
> > everything up into this little series.
> >
> > A follow-up could (but does not have to) turn translated action names
> > into untranslated git command names in some places.
>
> Thank you for persisting on this, and on behalf of the core Git reviewers
> I would like to apologize for the hornets' nest.

No need to. After all, this thoroughness is a huge part of what makes
git into what it is.

It's also why I'ven been participating much less: simply for lack of
time. That thoroughness takes time, sometimes much more than expected
(and can be frustrating, even in the very technical-physical meaning).
But discussions here are always about the best solution (not "whose"
solution "wins"), and that is why I'm always happy to be back for a
bit.

> I offer my ACK to this iteration of the patch series, with or without the
> v2 of patch 4/4.

Thanks!

Personally, I care only about the consistent reflog, which currently
means untranslated. Not that I look at the reflog all the time, but
...

Michael