Message ID | cover.1699609940.git.ps@pks.im (mailing list archive) |
---|---|
Headers | show |
Series | Replace use of `test <expr> -o/a <expr>` | expand |
On Fri, Nov 10, 2023 at 11:01:11AM +0100, Patrick Steinhardt wrote: > this is the second version of my patch series that replaces all uses of > `test <expr> -o/a <expr`. > > Changes compared to v1: > > - I've expanded a bit on why we want to do these conversions in the > first place in the first commit message. > > - Dropped a needless subshell and added missing quoting while at it. > > - Explained why we need to decompose the asserts in the second patch > into two asserts. These look OK to me. I mentioned a small nit on the first patch, but I am OK with ignoring it (and we are reaching diminishing returns polishing an otherwise trivial series). -Peff