| Message ID | cover.1711398665.git.dsimic@manjaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Assorted improvements salvaged from an earlier series | expand |
On Mon, Mar 25, 2024 at 4:34 PM Dragan Simic <dsimic@manjaro.org> wrote: > This series contains patches salvaged from my earlier series, [1] for > which it has been concluded to be not acceptable for merging, because of > possible issues with various git scripts. [2] > > Changes introduced to the patches are described separately in each patch. Prose description of the changes between versions is very much welcome by reviewers, but please also include a range-diff[1] or interdiff[2] when preparing a reroll. [1]: git format-patch --range-diff=<prev> ... [2]: git format-patch --interdiff=<prev> ...
On 2024-03-25 21:39, Eric Sunshine wrote: > On Mon, Mar 25, 2024 at 4:34 PM Dragan Simic <dsimic@manjaro.org> > wrote: >> This series contains patches salvaged from my earlier series, [1] for >> which it has been concluded to be not acceptable for merging, because >> of >> possible issues with various git scripts. [2] >> >> Changes introduced to the patches are described separately in each >> patch. > > Prose description of the changes between versions is very much welcome > by reviewers, but please also include a range-diff[1] or interdiff[2] > when preparing a reroll. > > [1]: git format-patch --range-diff=<prev> ... > [2]: git format-patch --interdiff=<prev> ... Ah, sorry, I didn't forget about that, but I just intended to start providing range-diffs for future patches. These were more like new versions of old patches.
On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@manjaro.org> wrote: > On 2024-03-25 21:39, Eric Sunshine wrote: > > Prose description of the changes between versions is very much welcome > > by reviewers, but please also include a range-diff[1] or interdiff[2] > > when preparing a reroll. > > Ah, sorry, I didn't forget about that, but I just intended to start > providing range-diffs for future patches. These were more like new > versions of old patches. The range-diff is particularly valuable exactly for this case (new versions of old patches) since it is a "diff" between the old patches and the new patches. Thus, it provides reviewers with a precise summary of what changed between, say, v2 and v3 of a series, and manifests as a concrete representation of what your prose explanation describes.
On 2024-03-25 21:49, Eric Sunshine wrote: > On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@manjaro.org> > wrote: >> On 2024-03-25 21:39, Eric Sunshine wrote: >> > Prose description of the changes between versions is very much welcome >> > by reviewers, but please also include a range-diff[1] or interdiff[2] >> > when preparing a reroll. >> >> Ah, sorry, I didn't forget about that, but I just intended to start >> providing range-diffs for future patches. These were more like new >> versions of old patches. > > The range-diff is particularly valuable exactly for this case (new > versions of old patches) since it is a "diff" between the old patches > and the new patches. Thus, it provides reviewers with a precise > summary of what changed between, say, v2 and v3 of a series, and > manifests as a concrete representation of what your prose explanation > describes. I see, and I do understand the purpose of range-diffs: they make reviewing new patch versions significantly easier, by relieving the reviewers from the need to track down what has been changed in the current patch version.
Hello Eric, On 2024-03-25 21:54, Dragan Simic wrote: > On 2024-03-25 21:49, Eric Sunshine wrote: >> On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@manjaro.org> >> wrote: >>> On 2024-03-25 21:39, Eric Sunshine wrote: >>> > Prose description of the changes between versions is very much welcome >>> > by reviewers, but please also include a range-diff[1] or interdiff[2] >>> > when preparing a reroll. >>> >>> Ah, sorry, I didn't forget about that, but I just intended to start >>> providing range-diffs for future patches. These were more like new >>> versions of old patches. >> >> The range-diff is particularly valuable exactly for this case (new >> versions of old patches) since it is a "diff" between the old patches >> and the new patches. Thus, it provides reviewers with a precise >> summary of what changed between, say, v2 and v3 of a series, and >> manifests as a concrete representation of what your prose explanation >> describes. > > I see, and I do understand the purpose of range-diffs: they make > reviewing new patch versions significantly easier, by relieving the > reviewers from the need to track down what has been changed in the > current patch version. As a note, I kept my promise :) and have started providing range-diffs in patch submissions. [1] [1] https://lore.kernel.org/git/e3212c0a4ad331685c68c13afcdbced20982ab32.1712364420.git.dsimic@manjaro.org/T/#u
On Fri, Apr 5, 2024 at 8:52 PM Dragan Simic <dsimic@manjaro.org> wrote: > On 2024-03-25 21:54, Dragan Simic wrote: > > On 2024-03-25 21:49, Eric Sunshine wrote: > >> The range-diff is particularly valuable exactly for this case (new > >> versions of old patches) since it is a "diff" between the old patches > >> and the new patches. Thus, it provides reviewers with a precise > >> summary of what changed between, say, v2 and v3 of a series, and > >> manifests as a concrete representation of what your prose explanation > >> describes. > > > > I see, and I do understand the purpose of range-diffs: they make > > reviewing new patch versions significantly easier, by relieving the > > reviewers from the need to track down what has been changed in the > > current patch version. > > As a note, I kept my promise :) and have started providing range-diffs > in patch submissions. [1] Glad to hear. Thanks.
This series contains patches salvaged from my earlier series, [1] for which it has been concluded to be not acceptable for merging, because of possible issues with various git scripts. [2] Changes introduced to the patches are described separately in each patch. Link to v1: https://lore.kernel.org/git/cover.1710968761.git.dsimic@manjaro.org/T/#u Link to v2: https://lore.kernel.org/git/cover.1711302588.git.dsimic@manjaro.org/T/#u [1] https://lore.kernel.org/git/cover.1710781235.git.dsimic@manjaro.org/T/#u [2] https://lore.kernel.org/git/d8475579f014a90b27efaf6207bc6fb0@manjaro.org/ Dragan Simic (3): grep: perform some minor code and comment cleanups grep docs: describe --recurse-submodules further and improve formatting a bit grep docs: describe --no-index further and improve formatting a bit Documentation/config/grep.txt | 2 +- Documentation/git-grep.txt | 36 +++++++++++++++++++++-------------- builtin/grep.c | 21 ++++++++------------ 3 files changed, 31 insertions(+), 28 deletions(-)