[0/2] t0610: fix umask tests

Message

Patrick Steinhardt April 9, 2024, 9:57 a.m. UTC

Hi,

these patches address the issue reported by Junio where running t0610
with an umask of 0027 breaks some tests. The root cause of this is quite
simple: we executed git-pack-refs(1) outside of the shell that had the
modified umask, and thus we ran tests with the umask of the host shell
by accident.

The series fixes this issue and extends the tests to exercise more
umasks than just 002 and 022, which would have caught the issue earlier.

Patrick

Patrick Steinhardt (2):
  t0610: make `--shared=` tests reusable
  t0610: execute git-pack-refs(1) with specified umask

 t/t0610-reftable-basics.sh | 67 ++++++++++++++++++++++----------------
 1 file changed, 39 insertions(+), 28 deletions(-)

Comments

Justin Tobler April 10, 2024, 9:49 p.m. UTC | #1

On 24/04/09 11:57AM, Patrick Steinhardt wrote:
> Hi,
> 
> these patches address the issue reported by Junio where running t0610
> with an umask of 0027 breaks some tests. The root cause of this is quite
> simple: we executed git-pack-refs(1) outside of the shell that had the
> modified umask, and thus we ran tests with the umask of the host shell
> by accident.
> 
> The series fixes this issue and extends the tests to exercise more
> umasks than just 002 and 022, which would have caught the issue earlier.
> 
> Patrick
> 
> Patrick Steinhardt (2):
>   t0610: make `--shared=` tests reusable
>   t0610: execute git-pack-refs(1) with specified umask
> 
>  t/t0610-reftable-basics.sh | 67 ++++++++++++++++++++++----------------
>  1 file changed, 39 insertions(+), 28 deletions(-)
> 
> -- 
> 2.44.GIT
> 

Nice fix! I like how the tests were made more extensible too. This looks
good to me :)

-Justin