[0/5] scalar: implement the subcommand "diagnose"

Message

Philippe Blain via GitGitGadget Jan. 26, 2022, 8:41 a.m. UTC

Over the course of the years, we developed a sub-command that gathers
diagnostic data into a .zip file that can then be attached to bug reports.
This sub-command turned out to be very useful in helping Scalar developers
identify and fix issues.

Johannes Schindelin (3):
  Implement `scalar diagnose`
  scalar diagnose: include disk space information
  scalar diagnose: show a spinner while staging content

Matthew John Cheetham (2):
  scalar: teach `diagnose` to gather packfile info
  scalar: teach `diagnose` to gather loose objects information

 contrib/scalar/scalar.c          | 336 +++++++++++++++++++++++++++++++
 contrib/scalar/scalar.txt        |  12 ++
 contrib/scalar/t/t9099-scalar.sh |  17 ++
 3 files changed, 365 insertions(+)


base-commit: ddc35d833dd6f9e8946b09cecd3311b8aa18d295
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1128%2Fdscho%2Fscalar-diagnose-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1128/dscho/scalar-diagnose-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1128

Comments

Derrick Stolee Jan. 27, 2022, 3:19 p.m. UTC | #1

On 1/26/2022 3:41 AM, Johannes Schindelin via GitGitGadget wrote:
> Over the course of the years, we developed a sub-command that gathers
> diagnostic data into a .zip file that can then be attached to bug reports.
> This sub-command turned out to be very useful in helping Scalar developers
> identify and fix issues.

For historical context: The 'diagnose' command was implemented in VFS for
Git and ported to the C# version of Scalar before 'git bugreport' existed,
but they serve very similar purposes.

I wonder if 'scalar diagnose' could include some of the information
captured by 'git bugreport' or whether this implementation of 'diagnose'
could help inform 'git bugreport' in any way.

CC'ing Emily for thoughts.

Thanks,
-Stolee

Johannes Schindelin Feb. 6, 2022, 9:13 p.m. UTC | #2

Hi Stolee & Emily,

On Thu, 27 Jan 2022, Derrick Stolee wrote:

> On 1/26/2022 3:41 AM, Johannes Schindelin via GitGitGadget wrote:
> > Over the course of the years, we developed a sub-command that gathers
> > diagnostic data into a .zip file that can then be attached to bug reports.
> > This sub-command turned out to be very useful in helping Scalar developers
> > identify and fix issues.
>
> For historical context: The 'diagnose' command was implemented in VFS for
> Git and ported to the C# version of Scalar before 'git bugreport' existed,
> but they serve very similar purposes.
>
> I wonder if 'scalar diagnose' could include some of the information
> captured by 'git bugreport' or whether this implementation of 'diagnose'
> could help inform 'git bugreport' in any way.

Indeed, I think that the `bugreport` command could easily benefit from at
least the number of pack files and loose objects.

Ciao,
Dscho

>
> CC'ing Emily for thoughts.
>
> Thanks,
> -Stolee
>