mbox series

[v2,0/3] tweaks to refs/debug.c

Message ID pull.1163.v2.git.git.1640196714.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series tweaks to refs/debug.c | expand

Message

Philippe Blain via GitGitGadget Dec. 22, 2021, 6:11 p.m. UTC 
these are two small commits that helped me while debugging reftable support
for git.

Han-Wen Nienhuys (3):
  refs: pass gitdir to packed_ref_store_create
  refs: print error message in debug output
  refs: centralize initialization of the base ref_store.

 refs.c                |  6 ++++--
 refs/debug.c          |  6 ++++--
 refs/files-backend.c  | 10 +++-------
 refs/packed-backend.c | 11 +++++------
 refs/packed-backend.h |  2 +-
 refs/refs-internal.h  |  4 ++--
 6 files changed, 19 insertions(+), 20 deletions(-)


base-commit: 69a9c10c95e28df457e33b3c7400b16caf2e2962
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1163%2Fhanwen%2Fdebug-tweaks-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1163/hanwen/debug-tweaks-v2
Pull-Request: https://github.com/git/git/pull/1163

Range-diff vs v1:

 -:  ----------- > 1:  bfebb5f08fe refs: pass gitdir to packed_ref_store_create
 1:  177d84f8563 = 2:  b189f8661e2 refs: print error message in debug output
 2:  75e5392032d < -:  ----------- refs: set the repo in debug_ref_store.base
 -:  ----------- > 3:  eea294b688f refs: centralize initialization of the base ref_store.

Comments

Junio C Hamano Dec. 22, 2021, 9:54 p.m. UTC | #1 
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:

> these are two small commits that helped me while debugging reftable support
> for git.
>
> Han-Wen Nienhuys (3):
>   refs: pass gitdir to packed_ref_store_create
>   refs: print error message in debug output
>   refs: centralize initialization of the base ref_store.

Welcome to our "we cannot count to three" club ;-)

All three patches make sense to me.  Especially the [3/3] has become
much easier to understand.

Thanks, will queue.