| Message ID | pull.40.v4.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | contrib: Add script to show uncovered "new" lines | expand |
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > CHANGES IN V4: I reduced the blame output using -s which decreases the > width. I include a summary of the commit authors at the end to help people > see the lines they wrote. This version is also copied into a build > definition in the public Git project on Azure Pipelines [1]. I'll use this > build definition to generate the coverage report after each "What's Cooking" > email. > > [1] https://git.visualstudio.com/git/_build?definitionId=5 Thanks. Let's move this forward by merging it down to 'next'.
On 10/11/2018 11:01 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> CHANGES IN V4: I reduced the blame output using -s which decreases the >> width. I include a summary of the commit authors at the end to help people >> see the lines they wrote. This version is also copied into a build >> definition in the public Git project on Azure Pipelines [1]. I'll use this >> build definition to generate the coverage report after each "What's Cooking" >> email. >> >> [1] https://git.visualstudio.com/git/_build?definitionId=5 > Thanks. Let's move this forward by merging it down to 'next'. Sounds good. When it moves into 'master' I can update my build to call the script from source. Thanks, -Stolee
We have coverage targets in our Makefile for using gcov to display line coverage based on our test suite. The way I like to do it is to run: make coverage-test make coverage-report This leaves the repo in a state where every X.c file that was covered has an X.c.gcov file containing the coverage counts for every line, and "#####" at every uncovered line. There have been a few bugs in recent patches what would have been caught if the test suite covered those blocks (including a few of mine). I want to work towards a "sensible" amount of coverage on new topics. In my opinion, this means that any logic should be covered, but the 'die()' blocks in error cases do not need to be covered. It is important to not measure the coverage of the codebase by what old code is not covered. To help, I created the 'contrib/coverage-diff.sh' script. After creating the coverage statistics at a version (say, 'topic') you can then run contrib/coverage-diff.sh base topic to see the lines added between 'base' and 'topic' that are not covered by the test suite. For example, I ran this against the 'next' branch (e82ca0) versus 'master' (f84b9b) and got the following output: builtin/commit.c 76f2f5c1e3 builtin/commit.c 1657) write_commit_graph_reachable(get_object_directory(), 0, 0); builtin/fsck.c 66ec0390e7 builtin/fsck.c 862) midx_argv[2] = "--object-dir"; 66ec0390e7 builtin/fsck.c 863) midx_argv[3] = alt->path; 66ec0390e7 builtin/fsck.c 864) if (run_command(&midx_verify)) 66ec0390e7 builtin/fsck.c 865) errors_found |= ERROR_COMMIT_GRAPH; fsck.c fb8952077d 214) die_errno("Could not read '%s'", path); midx.c 56ee7ff156 949) return 0; cc6af73c02 990) midx_report(_("failed to load pack-index for packfile %s"), cc6af73c02 991) e.p->pack_name); cc6af73c02 992) break; Commits introducing uncovered code: Derrick Stolee 56ee7ff15: multi-pack-index: add 'verify' verb Derrick Stolee 66ec0390e: fsck: verify multi-pack-index Derrick Stolee cc6af73c0: multi-pack-index: verify object offsets Junio C Hamano 76f2f5c1e: Merge branch 'ab/commit-graph-progress' into next René Scharfe fb8952077: fsck: use strbuf_getline() to read skiplist file Thanks, -Stolee CHANGES IN V3: I took Junio's perl script verbatim, which speeds up the performance greatly. Some of the other sed commands needed some massaging, but also added extra cleanup. Thanks for the help! CHANGES IN V4: I reduced the blame output using -s which decreases the width. I include a summary of the commit authors at the end to help people see the lines they wrote. This version is also copied into a build definition in the public Git project on Azure Pipelines [1]. I'll use this build definition to generate the coverage report after each "What's Cooking" email. [1] https://git.visualstudio.com/git/_build?definitionId=5 Derrick Stolee (1): contrib: add coverage-diff script contrib/coverage-diff.sh | 108 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 108 insertions(+) create mode 100755 contrib/coverage-diff.sh base-commit: 1d4361b0f344188ab5eec6dcea01f61a3a3a1670 Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-40%2Fderrickstolee%2Fcoverage-v4 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-40/derrickstolee/coverage-v4 Pull-Request: https://github.com/gitgitgadget/git/pull/40 Range-diff vs v3: 1: 21214cc321 ! 1: 6daf310a43 contrib: add coverage-diff script @@ -26,10 +26,10 @@ contrib/coverage-diff.sh base topic to see the lines added between 'base' and 'topic' that are not covered by the - test suite. The output uses 'git blame -c' format so you can find the commits - responsible and view the line numbers for quick access to the context. + test suite. The output uses 'git blame -s' format so you can find the commits + responsible and view the line numbers for quick access to the context, but + trims leading tabs in the file contents to reduce output width. - Helped-by: Junio C Hamano <gister@pobox.com> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> diff --git a/contrib/coverage-diff.sh b/contrib/coverage-diff.sh @@ -81,13 +81,16 @@ + ' +} + -+files=$(git diff --name-only $V1 $V2 -- *.c) ++files=$(git diff --name-only "$V1" "$V2" -- \*.c) ++ ++# create empty file ++>coverage-data.txt + +for file in $files +do -+ git diff $V1 $V2 -- $file \ -+ | diff_lines \ -+ | sort >new_lines.txt ++ git diff "$V1" "$V2" -- "$file" | ++ diff_lines | ++ sort >new_lines.txt + + if ! test -s new_lines.txt + then @@ -95,24 +98,50 @@ + fi + + hash_file=$(echo $file | sed "s/\//\#/") ++ ++ if ! test -s "$hash_file.gcov" ++ then ++ continue ++ fi ++ + sed -ne '/#####:/{ + s/ #####:// + s/:.*// + s/ //g + p -+ }' "$hash_file.gcov" \ -+ | sort >uncovered_lines.txt ++ }' "$hash_file.gcov" | ++ sort >uncovered_lines.txt + -+ comm -12 uncovered_lines.txt new_lines.txt \ -+ | sed -e 's/$/\)/' \ -+ | sed -e 's/^/\t/' \ -+ >uncovered_new_lines.txt ++ comm -12 uncovered_lines.txt new_lines.txt | ++ sed -e 's/$/\)/' | ++ sed -e 's/^/ /' >uncovered_new_lines.txt + -+ grep -q '[^[:space:]]' < uncovered_new_lines.txt && \ -+ echo $file && \ -+ git blame -c $file \ -+ | grep -f uncovered_new_lines.txt ++ grep -q '[^[:space:]]' <uncovered_new_lines.txt && ++ echo $file >>coverage-data.txt && ++ git blame -s "$V2" -- "$file" | ++ sed 's/\t//g' | ++ grep -f uncovered_new_lines.txt >>coverage-data.txt && ++ echo >>coverage-data.txt + + rm -f new_lines.txt uncovered_lines.txt uncovered_new_lines.txt +done + ++cat coverage-data.txt ++ ++echo "Commits introducing uncovered code:" ++ ++commit_list=$(cat coverage-data.txt | ++ grep -E '^[0-9a-f]{7,} ' | ++ awk '{print $1;}' | ++ sort | ++ uniq) ++ ++( ++ for commit in $commit_list ++ do ++ git log --no-decorate --pretty=format:'%an %h: %s' -1 $commit ++ echo ++ done ++) | sort ++ ++rm coverage-data.txt