diff mbox series

[v2,2/2] an improvement: removed configure.ac changes

Message ID 05df5d7e2d50cba77f53273c781f97d24144efc6.1708660111.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series This PR enables a successful git build on z/OS. | expand

Commit Message

Haritha D Feb. 23, 2024, 3:48 a.m. UTC 
From: Haritha D <harithamma.d@ibm.com>

Hello Reviewers, as an improvement, I have
removed the CC_LD_DYNPATH changes because
I was able to achieve the desired outcome
by passing it to the make step.

Signed-off-by: Haritha D <harithamma.d@ibm.com>
---
 configure.ac | 3 ---
 1 file changed, 3 deletions(-)

Comments

Junio C Hamano Feb. 23, 2024, 7:38 a.m. UTC | #1 
"Haritha D via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Haritha D <harithamma.d@ibm.com>
>
> Hello Reviewers, as an improvement, I have
> removed the CC_LD_DYNPATH changes because
> I was able to achieve the desired outcome
> by passing it to the make step.
>
> Signed-off-by: Haritha D <harithamma.d@ibm.com>
> ---
>  configure.ac | 3 ---
>  1 file changed, 3 deletions(-)

We frown upon a patch series that makes mistakes in an earlier step,
only to fix them in a later step.  The "git rebase -i" command helps
us pretend to be more perfect developers than we actually are,
whipping your patch series into a shape that builds one small step
on top of another in a logical succession.  Such a patch series is
easier to understand than a history that faithfully records all the
stumbles the developer made until they reached the final solution.

In this case, if you know before you sent these two patches that you
do not need to touch configure.ac for CC_LD_DYNPATH at all, you can
"git rebase -i" to whip the first patch into the desired shape, i.e.
no changes to configure.ac, and drop this second patch, I think.

> diff --git a/configure.ac b/configure.ac
> index 64569a80d53..d1a96da14eb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -463,9 +463,6 @@ else
>              CC_LD_DYNPATH=-Wl,+b,
>            else
>               CC_LD_DYNPATH=
> -	     if test "$(uname -s)" = "OS/390"; then
> -		     CC_LD_DYNPATH=-L
> -	     fi
>               AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
>            fi
>        fi
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 64569a80d53..d1a96da14eb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -463,9 +463,6 @@  else
             CC_LD_DYNPATH=-Wl,+b,
           else
              CC_LD_DYNPATH=
-	     if test "$(uname -s)" = "OS/390"; then
-		     CC_LD_DYNPATH=-L
-	     fi
              AC_MSG_WARN([linker does not support runtime path to dynamic libraries])
           fi
       fi