| Message ID | 191922c8f28c338ab3aa4faa57d75770a9eccd02.1631657157.git.me@ttaylorr.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pack-bitmap: permute existing namehash values | expand |
On Tue, Sep 14, 2021 at 06:06:11PM -0400, Taylor Blau wrote: > When this performance test was originally written, `core.multiPackIndex` > was not the default and thus had to be enabled. But now that we have > 18e449f86b (midx: enable core.multiPackIndex by default, 2020-09-25), we > no longer need this. > > Drop the unnecessary setup (even though it's not hurting anything, it is > unnecessary at best and confusing at worst). Makes sense. Sometimes it is worthwhile to carry extra code in the perf tests for older versions, so that we can test performance across a wider span. But there were no midx bitmaps at all when 18e449f86b happened, so there is little point in worrying about going back that far for this test. -Peff
diff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh index 51b5636259..a9c5499537 100755 --- a/t/perf/p5326-multi-pack-bitmaps.sh +++ b/t/perf/p5326-multi-pack-bitmaps.sh @@ -6,10 +6,6 @@ test_description='Tests performance using midx bitmaps' test_perf_large_repo -test_expect_success 'enable multi-pack index' ' - git config core.multiPackIndex true -' - # we need to create the tag up front such that it is covered by the repack and # thus by generated bitmaps. test_expect_success 'create tags' '
When this performance test was originally written, `core.multiPackIndex` was not the default and thus had to be enabled. But now that we have 18e449f86b (midx: enable core.multiPackIndex by default, 2020-09-25), we no longer need this. Drop the unnecessary setup (even though it's not hurting anything, it is unnecessary at best and confusing at worst). Signed-off-by: Taylor Blau <me@ttaylorr.com> --- t/perf/p5326-multi-pack-bitmaps.sh | 4 ---- 1 file changed, 4 deletions(-)