| Message ID | 1a40161baf13224228d9c755db8ce2bdeb06917a.1632880469.git.me@ttaylorr.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | repack: introduce `--write-midx` | expand |
diff --git a/builtin/repack.c b/builtin/repack.c index 5539ec7e89..475677b297 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -446,6 +446,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) struct strbuf line = STRBUF_INIT; int i, ext, ret; FILE *out; + int show_progress = isatty(2); /* variables to be filled by option parsing */ int pack_everything = 0; @@ -719,7 +720,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix) } strbuf_release(&buf); } - if (!po_args.quiet && isatty(2)) + if (!po_args.quiet && show_progress) opts |= PRUNE_PACKED_VERBOSE; prune_packed_objects(opts);
We only ask whether stderr is a tty before calling 'prune_packed_objects()', but the subsequent patch will add another use. Extract this check into a variable so that both can use it without having to call 'isatty()' twice. Signed-off-by: Taylor Blau <me@ttaylorr.com> --- builtin/repack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)