| Message ID | 20181016234550.216587-1-sbeller@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | builtin/submodule--helper: remove debugging leftover tracing | expand |
Stefan Beller wrote: > I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree > by ensure-core-worktree, 2018-08-13) had two leftover debugging statements > when reading The coverage report [1]. Remove them. > > https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/ > > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > builtin/submodule--helper.c | 2 -- > 1 file changed, 2 deletions(-) Doh. Glad you caught it! Is there some reference for The Coverage Report other than the mailing list? E.g. I suspect a reference to make coverage-test make coverage-report would be useful to readers finding this commit later. > To be applied on (or squashed into the tip of) > sb/submodule-update-in-c Looks like that's already in "master", so not a candidate for squashing. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 5c9d1fb496..c7d3841ffc 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1459,7 +1459,6 @@ static void determine_submodule_update_strategy(struct repository *r, key = xstrfmt("submodule.%s.update", sub->name); if (update) { - trace_printf("parsing update"); if (parse_submodule_update_strategy(update, out) < 0) die(_("Invalid update mode '%s' for submodule path '%s'"), update, path); @@ -1468,7 +1467,6 @@ static void determine_submodule_update_strategy(struct repository *r, die(_("Invalid update mode '%s' configured for submodule path '%s'"), val, path); } else if (sub->update_strategy.type != SM_UPDATE_UNSPECIFIED) { - trace_printf("loaded thing"); out->type = sub->update_strategy.type; out->command = sub->update_strategy.command; } else
I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree, 2018-08-13) had two leftover debugging statements when reading The coverage report [1]. Remove them. https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/ Signed-off-by: Stefan Beller <sbeller@google.com> --- To be applied on (or squashed into the tip of) sb/submodule-update-in-c builtin/submodule--helper.c | 2 -- 1 file changed, 2 deletions(-)