diff mbox series

[20/24] submodule: don't add submodule as odb for push

Message ID	20181030220817.61691-21-sbeller@google.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> Date: Tue, 30 Oct 2018 15:08:13 -0700 In-Reply-To: <20181030220817.61691-1-sbeller@google.com> Message-Id: <20181030220817.61691-21-sbeller@google.com> Mime-Version: 1.0 References: <20181030220817.61691-1-sbeller@google.com> Subject: [PATCH 20/24] submodule: don't add submodule as odb for push From: Stefan Beller <sbeller@google.com> To: git@vger.kernel.org Cc: szeder.dev@gmail.com, jonathantanmy@google.com, Stefan Beller <sbeller@google.com> Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Bring more repository handles into our code base] \| expand [PATCHv2,00/24] Bring more repository handles into our code base] [01/24] Makefile: add pending semantic patches [02/24] sha1_file: allow read_object to read objects in arbitrary repositories [03/24] packfile: allow has_packed_and_bad to handle arbitrary repositories [04/24] object-store: allow read_object_file_extended to read from arbitrary repositories [05/24] object-store: prepare read_object_file to deal with arbitrary repositories [06/24] object-store: prepare has_{sha1, object}_file[_with_flags] to handle arbitrary repositories [07/24] object: parse_object to honor its repository argument [08/24] commit: allow parse_commit* to handle arbitrary repositories [09/24] commit-reach.c: allow paint_down_to_common to handle arbitrary repositories [10/24] commit-reach.c: allow merge_bases_many to handle arbitrary repositories [11/24] commit-reach.c: allow remove_redundant to handle arbitrary repositories [12/24] commit-reach.c: allow get_merge_bases_many_0 to handle arbitrary repositories [13/24] commit-reach: prepare get_merge_bases to handle arbitrary repositories [14/24] commit-reach: prepare in_merge_bases[_many] to handle arbitrary repositories [15/24] commit: prepare get_commit_buffer to handle arbitrary repositories [16/24] commit: prepare repo_unuse_commit_buffer to handle arbitrary repositories [17/24] commit: prepare logmsg_reencode to handle arbitrary repositories [18/24] pretty: prepare format_commit_message to handle arbitrary repositories [19/24] submodule: use submodule repos for object lookup [20/24] submodule: don't add submodule as odb for push [21/24] commit-graph: convert remaining function to handle arbitrary repositories [22/24] commit: make free_commit_buffer and release_commit_memory repository agnostic [23/24] path.h: make REPO_GIT_PATH_FUNC repository agnostic [24/24] t/helper/test-repository: celebrate independence from the_repository

Commit Message

Stefan Beller Oct. 30, 2018, 10:08 p.m. UTC

In push_submodule(), because we do not actually need access to objects
in the submodule, do not invoke add_submodule_odb().
(for_each_remote_ref_submodule() does not require access to those
objects, and the actual push is done by spawning another process,
which handles object access by itself.)

This code of push_submodule() is exercised in t5531 and continues
to work, showing that the submodule odbc is not needed.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 submodule.c | 3 ---
 1 file changed, 3 deletions(-)

diff mbox series

Patch

diff --git a/submodule.c b/submodule.c
index 0fdda45252..da1ac1e6f8 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1024,9 +1024,6 @@  static int push_submodule(const char *path,
 			  const struct string_list *push_options,
 			  int dry_run)
 {
-	if (add_submodule_odb(path))
-		return 1;
-
 	if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
 		struct child_process cp = CHILD_PROCESS_INIT;
 		argv_array_push(&cp.args, "push");