diff mbox series

[3/4] rev-list-options.txt: do not nest open blocks

Message ID 20181215112742.1475882-4-martin.agren@gmail.com (mailing list archive)
State New, archived
Headers show
Series A few Asciidoctor-fixes | expand

Commit Message

Martin Ågren Dec. 15, 2018, 11:27 a.m. UTC
Similar to the previous commit, it appears we try to nest open blocks,
which does not work well with Asciidoctor. Drop the outer one. That
fixes the indentation similar to the previous patch, and makes us stop
rendering a literal '+' before "Under --pretty=oneline ...". Asciidoc
renders identically before and after this patch, both man-page and html.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 See https://git-scm.com/docs/git-log#git-log--g and
 https://git-scm.com/docs/git-rev-list#git-rev-list--g . The indentation
 doesn't look too bad, but the "+ Under" is clearly wrong.

 Documentation/rev-list-options.txt | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jeff King Dec. 16, 2018, 10:56 a.m. UTC | #1
On Sat, Dec 15, 2018 at 12:27:41PM +0100, Martin Ågren wrote:

> Similar to the previous commit, it appears we try to nest open blocks,
> which does not work well with Asciidoctor. Drop the outer one. That
> fixes the indentation similar to the previous patch, and makes us stop
> rendering a literal '+' before "Under --pretty=oneline ...". Asciidoc
> renders identically before and after this patch, both man-page and html.

Makes sense. Arguably this could be squashed into the previous one,
since the rationale is completely the same (but I'm OK with it either
way).

-Peff
diff mbox series

Patch

diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
index bab5f50b17..98b538bc77 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -13,8 +13,6 @@  has a line that matches `<pattern>`), unless otherwise noted.
 Note that these are applied before commit
 ordering and formatting options, such as `--reverse`.
 
---
-
 -<number>::
 -n <number>::
 --max-count=<number>::
@@ -308,8 +306,6 @@  ifdef::git-rev-list[]
 	`<header>` text will be printed with each progress update.
 endif::git-rev-list[]
 
---
-
 History Simplification
 ~~~~~~~~~~~~~~~~~~~~~~