[13/19] rev-parseopt: convert --not

Message ID	20190508111249.15262-14-pclouds@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> To: git@vger.kernel.org Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> Subject: [PATCH 13/19] rev-parseopt: convert --not Date: Wed, 8 May 2019 18:12:43 +0700 Message-Id: <20190508111249.15262-14-pclouds@gmail.com> In-Reply-To: <20190508111249.15262-1-pclouds@gmail.com> References: <20190508111249.15262-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Convert revision.c to parseopt part 1/4 \| expand [00/19] Convert revision.c to parseopt part 1/4 [01/19] revision.h: avoid bit fields in struct rev_info [02/19] revision.h: move repo field down [03/19] revision.c: prepare to convert handle_revision_pseudo_opt() [04/19] rev-parseopt: convert --all [05/19] rev-parseopt: convert --branches [06/19] rev-parseopt: convert --bisect [07/19] rev-parseopt: convert --tags [08/19] rev-parseopt: convert --remotes [09/19] rev-parseopt: convert --glob [10/19] rev-parseopt: convert --exclude [11/19] rev-parseopt: convert --reflog [12/19] rev-parseopt: convert --indexed-objects [13/19] rev-parseopt: convert --not [14/19] rev-parseopt: convert --no-walk and --do-walk [15/19] rev-parseopt: convert --single-worktree [16/19] rev-parseopt: prepare to convert handle_revision_opt() [17/19] rev-parseopt: convert --max-count [18/19] rev-parseopt: convert --skip [19/19] rev-parseopt: convert --min-age and --max-age

Message ID

20190508111249.15262-14-pclouds@gmail.com (mailing list archive)

State

New, archived

Headers

From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
To: git@vger.kernel.org
Cc: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?=  <pclouds@gmail.com>
Subject: [PATCH 13/19] rev-parseopt: convert --not
Date: Wed,  8 May 2019 18:12:43 +0700
Message-Id: <20190508111249.15262-14-pclouds@gmail.com>
In-Reply-To: <20190508111249.15262-1-pclouds@gmail.com>
References: <20190508111249.15262-1-pclouds@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Convert revision.c to parseopt part 1/4 | expand

Commit Message

Duy Nguyen May 8, 2019, 11:12 a.m. UTC

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 revision.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/revision.c b/revision.c
index 9cfa4dc151..b02cb4660b 100644
--- a/revision.c
+++ b/revision.c
@@ -2464,6 +2464,17 @@  static int rev_opt_glob(const struct option *opt,
 	return 0;
 }
 
+static int rev_opt_not(const struct option *opt,
+		       const char *arg, int unset)
+{
+	struct rev_info *revs  = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+	BUG_ON_OPT_ARG(arg);
+	*revs->pseudo_flags ^= UNINTERESTING | BOTTOM;
+	return 0;
+}
+
 static int rev_opt_reflog(const struct option *opt,
 			  const char *arg, int unset)
 {
@@ -2558,6 +2569,9 @@  static void make_pseudo_options(struct rev_info *revs)
 		OPT_REV_NOARG(0, "indexed-objects",
 			      N_("include all trees and blobs used by the index"),
 			      rev_opt_indexed_objects),
+		OPT_REV_NOARG(0, "not",
+			      N_("reverse the meaning of '^' for all following revisions"),
+			      rev_opt_not),
 		OPT_END()
 	};
 	ALLOC_ARRAY(revs->pseudo_options, ARRAY_SIZE(options));
@@ -2597,9 +2611,7 @@  static int handle_revision_pseudo_opt(const char *submodule,
 	if (argc)
 		return argc;
 
-	if (!strcmp(arg, "--not")) {
-		*flags ^= UNINTERESTING | BOTTOM;
-	} else if (!strcmp(arg, "--no-walk")) {
+	if (!strcmp(arg, "--no-walk")) {
 		revs->no_walk = REVISION_WALK_NO_WALK_SORTED;
 	} else if (skip_prefix(arg, "--no-walk=", &optarg)) {
 		/*

[13/19] rev-parseopt: convert --not

Commit Message

Patch